You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/05/08 09:39:48 UTC
[PR] Skip date-shaped tags in upgrade_important_versions image bumper [airflow]
potiuk opened a new pull request, #66588:
URL: https://github.com/apache/airflow/pull/66588
## Summary
The CI image bumper auto-pinned `alpine:20260127` (a daily-edge tag) instead of `alpine:3.23` in apache/airflow#66580. Root cause: `packaging.version.Version("20260127")` parses as a valid single-component PEP 440 version and sorts **higher** than `3.23`, so the bumper's "latest version" selection picked Alpine's date-stamped daily build over the 3.23 release.
The same logic would auto-pin any other Docker Hub image to its date-stamped daily under the right circumstances — Alpine just happens to publish daily edge tags under a `YYYYMMDD` scheme that PEP 440 swallows whole.
## Fix
Pre-filter the tag list against a date-shaped regex (`v?\d{8}(\.\d+)?`) before parsing as a `Version`. Belt-and-braces: also reject parsed `Version` objects whose major component is implausibly large (≥ 10000), catching anything the regex misses. Added `edge` to the existing floating-tag skiplist while there.
## Tests
5 parametrised cases:
- alpine real-tag mix (release + date + edge): picks `3.23.5`, not `20260127`.
- busybox style (mixed dotted releases + bare-major aliases): picks `1.37.0`.
- `v`-prefixed date tags: picks `v3.23.5`, not `v20260127`.
- date-with-revision-suffix (`20260127.1`): still rejected.
- regex unit-test verifying it matches date-shaped tags only, not legitimate releases.
## Reproduces
apache/airflow#66580 (CI auto-bump PR).
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.7)
Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip date-shaped tags in upgrade_important_versions image bumper [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #66588:
URL: https://github.com/apache/airflow/pull/66588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip date-shaped tags in upgrade_important_versions image bumper [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66588:
URL: https://github.com/apache/airflow/pull/66588#issuecomment-4407768660
### Backport successfully created: v3-2-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/pull/66599"><img src="https://img.shields.io/badge/PR-66599-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org