You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/02 00:55:15 UTC

[GitHub] [arrow] edponce commented on pull request #12460: ARROW-13530: [C++] Implement cumulative sum compute function

edponce commented on pull request #12460:
URL: https://github.com/apache/arrow/pull/12460#issuecomment-1086441781


   @ianmcook @westonpace The current implementation of `cumulative_sum` only works on non-nested Arrays and ChunkedArrays, and performs a running cumulative sum. Looking at the code, it seems that the output of the ChunkedArray is a large Array.
   
   [I added comments to JIRA presenting the different behaviors of cumsum for nested inputs for pandas, numpy, and R.](https://issues.apache.org/jira/browse/ARROW-13530?focusedCommentId=17516180&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516180)
   
   What are your thoughts on handling nested types?
   
   PS. Most likely this PR will be scoped to include the basic implementation for numeric types and will have follow-up JIRA issues for date/time types and nested inputs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org