You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Curtiss Howard (JIRA)" <de...@myfaces.apache.org> on 2009/08/03 14:41:14 UTC

[jira] Created: (MYFACES-2302) Get simple 2.0 app working

Get simple 2.0 app working
--------------------------

                 Key: MYFACES-2302
                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
             Project: MyFaces Core
          Issue Type: Task
          Components: JSR-314
    Affects Versions: 2.0.0-alpha
            Reporter: Curtiss Howard


As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Curtiss Howard (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738497#action_12738497 ] 

Curtiss Howard commented on MYFACES-2302:
-----------------------------------------

Second set of fixes for these issues:

* FaceletViewDeclarationLanguage wasn't doing anything on restore.
* DefaultViewHandlerSupport.handlePrefixMapping() was removing the leading /.

I can now get the "Guess number 2.0" app running, though there is some sort of mechanism in use to display the result message that escapes me.  If I manually add it to the page, I see that the posting/lifecycle stuff is working though.  The custom validator tag is still not working.

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Curtiss Howard (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738666#action_12738666 ] 

Curtiss Howard commented on MYFACES-2302:
-----------------------------------------

Sorry, for some reason I got confused about the commented code since it referenced the state manager.  I'll try to get it working correctly.

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738583#action_12738583 ] 

Leonardo Uribe commented on MYFACES-2302:
-----------------------------------------

What is the problem related to:

* FaceletViewDeclarationLanguage wasn't doing anything on restore. 

Some commented code was uncomented but  the commented code should be removed! createView and buildView should be called from DefaultFaceletsStateManagementStrategy. If no partial state saving is used these methods should not be called and use jsf 1.2 style for state save and restore, since the whole tree is restored from state.

If no objections I'll rollback the change proposed for FaceletViewDeclarationLanguage.

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Curtiss Howard (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741332#action_12741332 ] 

Curtiss Howard commented on MYFACES-2302:
-----------------------------------------

Third set of fixes for these issues:

* FaceletViewDeclarationLanguage was not looking at the new Facelets init params (javax.faces.FACELETS_*) in addition to the deprecated ones (facelets.*).
* TagLibraryConfig was not able to handle version 2.0 Facelet taglib documents.

A note on the second point: I could not find the 2.0 Facelet taglib document schema in the Facelets CVS, so for now any 2.0 documents are not validated.  This will have to be addressed when the schema is publicly available.

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Curtiss Howard (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738382#action_12738382 ] 

Curtiss Howard commented on MYFACES-2302:
-----------------------------------------

First set of fixes for these issues:

* HtmlLibrary didn't declare some tags (head, body, etc.).
* ResourceResolver was placed too far down the composite EL resolver chain.
* ResourceResolver had bugs in the way it parsed the resource name.
* AnnotationConfigurator didn't handle the case where @ManagedBean.name() is empty.

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Jan-Kees van Andel (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738324#action_12738324 ] 

Jan-Kees van Andel commented on MYFACES-2302:
---------------------------------------------

Can you also test the annotations (like: @ManagedBean)?

I've committed some bugfixes last weekend to get the annotations working, but it's possible that I wasn't complete (I encountered these bugs while I was working on something else).

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2302) Get simple 2.0 app working

Posted by "Curtiss Howard (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742347#action_12742347 ] 

Curtiss Howard commented on MYFACES-2302:
-----------------------------------------

Fourth set of fixes for these issues:

* HtmlLinkRendererBase wasn't rendering HtmlOutcomeTargetLink components.
* HtmlLibrary didn't register renderers for HtmlOutcomeTargetButton and HtmlOutcomeTargetLink.
* NavigationHandlerImpl didn't implement part of the spec related to finding navigation cases when none are defined for the application.

I'm happy to report that the Mojarra "Guess number 2.0" sample app now works properly with MyFaces.  The last piece of work for this issue will be to change FaceletViewDeclarationLanguage such that the state management strategy is used to build/restore the view.

> Get simple 2.0 app working
> --------------------------
>
>                 Key: MYFACES-2302
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2302
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Curtiss Howard
>
> As a first attempt in getting the Facelets code work, I will try to get the "Guess number 2.0" app working.  This app tests resources and custom Facelets taglibs, so this should be a good way to tie together and fix all the code that's gone in so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.