[GitHub] [lucene-solr] megancarey opened a new pull request #826: SOLR-13399: add splitByPrefix configuration to IndexSizeTrigger

[GitBox <gi...@apache.org>]

megancarey opened a new pull request #826: SOLR-13399: add splitByPrefix configuration to IndexSizeTrigger
URL: https://github.com/apache/lucene-solr/pull/826
 
 
   <!--
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   I've added the `splitByPrefix` parameter to the IndexSizeTrigger, so that the trigger is able to execute shard splits by prefix. I also added test cases to validate the split configs baked into this trigger. 
   
   Plus, I made a small change to the splitByPrefix code for splitting by ID, and cleaned up the tests a bit.
   
   # Solution
   
   The solution I took to address this problem models the convention of JIRA-12942, which adds the split configs directly into the trigger config. 
   
   The change I made to the splitByPrefix code doesn't modify functionality at all, but the implementation uses BytesRef.bytesEquals instead of manually comparing byte arrays.
   
   # Tests
   
   I added additional checks to the test IndexSizeTriggerTest.testTrigger, which validates that the default split configs are added to the trigger config. I also added a check to IndexSizeTriggerTest.testSplitConfig that validates the splitByPrefix override. Finally, I added a test case that attempts trigger configuration with invalid configs, and fails.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [] I have created a Jira issue and added the issue ID to my pull request title.
     - I'm piggybacking on existing JIRA SOLR-13399
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [x] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org