You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hzjhjjyy (via GitHub)" <gi...@apache.org> on 2024/04/15 10:09:27 UTC
[PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
hzjhjjyy opened a new pull request, #3214:
URL: https://github.com/apache/paimon/pull/3214
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2956
and
1, add validation for bucket configuration.
2, fix typo.
3, close file read/wirte.
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
Posted by "hzjhjjyy (via GitHub)" <gi...@apache.org>.
hzjhjjyy commented on code in PR #3214:
URL: https://github.com/apache/paimon/pull/3214#discussion_r1566609144
##########
paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java:
##########
@@ -207,9 +207,9 @@ default void checkOrMkdirs(Path path) throws IOException {
/** Read file to UTF_8 decoding. */
default String readFileUtf8(Path path) throws IOException {
- try (SeekableInputStream in = newInputStream(path)) {
- BufferedReader reader =
- new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8));
+ try (SeekableInputStream in = newInputStream(path);
+ BufferedReader reader =
Review Comment:
ok, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3214:
URL: https://github.com/apache/paimon/pull/3214#discussion_r1565596196
##########
paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java:
##########
@@ -207,9 +207,9 @@ default void checkOrMkdirs(Path path) throws IOException {
/** Read file to UTF_8 decoding. */
default String readFileUtf8(Path path) throws IOException {
- try (SeekableInputStream in = newInputStream(path)) {
- BufferedReader reader =
- new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8));
+ try (SeekableInputStream in = newInputStream(path);
+ BufferedReader reader =
Review Comment:
Why modify here? It is already flushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3214:
URL: https://github.com/apache/paimon/pull/3214#discussion_r1565596442
##########
paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java:
##########
@@ -233,8 +233,9 @@ default boolean writeFileUtf8(Path path, String content) throws IOException {
Path tmp = path.createTempPath();
boolean success = false;
try {
- try (PositionOutputStream out = newOutputStream(tmp, false)) {
- OutputStreamWriter writer = new OutputStreamWriter(out, StandardCharsets.UTF_8);
+ try (PositionOutputStream out = newOutputStream(tmp, false);
+ OutputStreamWriter writer =
Review Comment:
Ditto.
##########
paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java:
##########
@@ -207,9 +207,9 @@ default void checkOrMkdirs(Path path) throws IOException {
/** Read file to UTF_8 decoding. */
default String readFileUtf8(Path path) throws IOException {
- try (SeekableInputStream in = newInputStream(path)) {
- BufferedReader reader =
- new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8));
+ try (SeekableInputStream in = newInputStream(path);
+ BufferedReader reader =
Review Comment:
Why modify here? It is already readed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3214:
URL: https://github.com/apache/paimon/pull/3214#discussion_r1566600037
##########
paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java:
##########
@@ -207,9 +207,9 @@ default void checkOrMkdirs(Path path) throws IOException {
/** Read file to UTF_8 decoding. */
default String readFileUtf8(Path path) throws IOException {
- try (SeekableInputStream in = newInputStream(path)) {
- BufferedReader reader =
- new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8));
+ try (SeekableInputStream in = newInputStream(path);
+ BufferedReader reader =
Review Comment:
It is just a wrapper, we already close the underly stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3214:
URL: https://github.com/apache/paimon/pull/3214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fixed the issue where deletes could not be performed when the table is in dynamic bucket mode. [paimon]
Posted by "hzjhjjyy (via GitHub)" <gi...@apache.org>.
hzjhjjyy commented on code in PR #3214:
URL: https://github.com/apache/paimon/pull/3214#discussion_r1565945856
##########
paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java:
##########
@@ -207,9 +207,9 @@ default void checkOrMkdirs(Path path) throws IOException {
/** Read file to UTF_8 decoding. */
default String readFileUtf8(Path path) throws IOException {
- try (SeekableInputStream in = newInputStream(path)) {
- BufferedReader reader =
- new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8));
+ try (SeekableInputStream in = newInputStream(path);
+ BufferedReader reader =
Review Comment:
It’s to add the remaining readers/writers to the try-with-resources block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org