You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/08 07:18:16 UTC

[GitHub] [incubator-doris] zhengshengjun commented on pull request #8908: [fix](load) start transaction before we need it (#8819)

zhengshengjun commented on PR #8908:
URL: https://github.com/apache/incubator-doris/pull/8908#issuecomment-1092530164

   > How about calling beginTnx() in `SparkLoadJob.unprotectedExecuteJob`, it seems more reasonable. Also closer to the original version. `SparkLoadJob` is responsible for transaction management, `SparkLoadPendingTask` is responsible for task execution.
   
   Good suggestion! I had thought to start transaction where it is now stared （in `SparkLoadPendingTask`). But it's more reasonable to manage a job level transaction in `SparkLoadJob` as you mentioned, fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org