You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2012/01/26 22:30:54 UTC
svn commit: r1236390 - in
/maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138:
mod-1/src/main/config/ mod-2/rulesets/
mod-2/src/main/java/test/MyClass.java verify.groovy
Author: rfscholte
Date: Thu Jan 26 21:30:54 2012
New Revision: 1236390
URL: http://svn.apache.org/viewvc?rev=1236390&view=rev
Log:
MPMD-138: Fix IT-tests by letting it reflect the core issue. Use default rules, use different failures
Removed:
maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-1/src/main/config/
maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-2/rulesets/
Modified:
maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-2/src/main/java/test/MyClass.java
maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/verify.groovy
Modified: maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-2/src/main/java/test/MyClass.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-2/src/main/java/test/MyClass.java?rev=1236390&r1=1236389&r2=1236390&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-2/src/main/java/test/MyClass.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/mod-2/src/main/java/test/MyClass.java Thu Jan 26 21:30:54 2012
@@ -2,11 +2,5 @@ package test;
public class MyClass
{
-
- public static void main( String[] args )
- {
- ;
- return;
- }
-
-}
+ private String x;
+}
\ No newline at end of file
Modified: maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/verify.groovy
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/verify.groovy?rev=1236390&r1=1236389&r2=1236390&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/verify.groovy (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/it/mpmd-138/verify.groovy Thu Jan 26 21:30:54 2012
@@ -22,12 +22,12 @@ File buildLog = new File( basedir, 'buil
assert buildLog.exists()
// Module 1
-assert 1 == buildLog.getText().count('[INFO] PMD Failure: test.MyClass:8 Rule:EmptyStatementNotInLoop Priority:3 An empty statement (semicolon) not part of a loop.')
-assert 1 == buildLog.getText().count('[INFO] PMD Failure: test.MyClass:9 Rule:UnnecessaryReturn Priority:3 Avoid unnecessary return statements.')
+assert 1 == buildLog.getText().count('[INFO] PMD Failure: test.MyClass:8 Rule:EmptyStatementNotInLoop Priority:3 An empty statement (semicolon) not part of a loop')
+assert 1 == buildLog.getText().count('[INFO] PMD Failure: test.MyClass:9 Rule:UnnecessaryReturn Priority:3 Avoid unnecessary return statements')
assert 1 == buildLog.getText().count('[INFO] You have 2 PMD violations. For more details see:')
// Module 2
-assert 1 == buildLog.getText().count('[INFO] PMD Failure: test.MyClass:8 Rule:EmptyStatementNotInLoop Priority:3 TEST: LOCAL-FILE-RULESET.')
+assert 1 == buildLog.getText().count('[INFO] PMD Failure: test.MyClass:5 Rule:UnusedPrivateField Priority:3 Avoid unused private fields such as \'x\'')
assert 1 == buildLog.getText().count('[INFO] You have 1 PMD violation. For more details see:')
// Module 3