You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/12/08 07:41:57 UTC
[PR] [#1361] feat(netty): add netty metrics into reporter [incubator-uniffle]
zuston opened a new pull request, #1362:
URL: https://github.com/apache/incubator-uniffle/pull/1362
### What changes were proposed in this pull request?
add netty metrics into reporter
### Why are the changes needed?
Fix: #1361
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Needn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1361] feat(netty): add netty metrics into reporter [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1362:
URL: https://github.com/apache/incubator-uniffle/pull/1362#issuecomment-1846716983
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`453e6d6`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/453e6d6948dd1bcc2f4f3425b493d7288931ffef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.27% compared to head [(`f11f838`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1362?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.45%.
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../java/org/apache/uniffle/server/ShuffleServer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1362 +/- ##
============================================
+ Coverage 53.27% 53.45% +0.18%
+ Complexity 2712 2182 -530
============================================
Files 418 341 -77
Lines 23913 15361 -8552
Branches 2043 1426 -617
============================================
- Hits 12739 8211 -4528
+ Misses 10388 6687 -3701
+ Partials 786 463 -323
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1362?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1361] feat(netty): add netty metrics into reporter [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1362:
URL: https://github.com/apache/incubator-uniffle/pull/1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1361] feat(netty): add netty metrics into reporter [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1362:
URL: https://github.com/apache/incubator-uniffle/pull/1362#discussion_r1420172363
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -311,6 +311,7 @@ private void initMetricsReporter() throws Exception {
if (metricReporter != null) {
metricReporter.addCollectorRegistry(ShuffleServerMetrics.getCollectorRegistry());
metricReporter.addCollectorRegistry(grpcMetrics.getCollectorRegistry());
+ metricReporter.addCollectorRegistry(nettyMetrics.getCollectorRegistry());
Review Comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1361] feat(netty): add netty metrics into reporter [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on code in PR #1362:
URL: https://github.com/apache/incubator-uniffle/pull/1362#discussion_r1420082114
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -311,6 +311,7 @@ private void initMetricsReporter() throws Exception {
if (metricReporter != null) {
metricReporter.addCollectorRegistry(ShuffleServerMetrics.getCollectorRegistry());
metricReporter.addCollectorRegistry(grpcMetrics.getCollectorRegistry());
+ metricReporter.addCollectorRegistry(nettyMetrics.getCollectorRegistry());
Review Comment:
It won't be null, the nettyMetrics always will be initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1361] feat(netty): add netty metrics into reporter [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1362:
URL: https://github.com/apache/incubator-uniffle/pull/1362#discussion_r1420080572
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -311,6 +311,7 @@ private void initMetricsReporter() throws Exception {
if (metricReporter != null) {
metricReporter.addCollectorRegistry(ShuffleServerMetrics.getCollectorRegistry());
metricReporter.addCollectorRegistry(grpcMetrics.getCollectorRegistry());
+ metricReporter.addCollectorRegistry(nettyMetrics.getCollectorRegistry());
Review Comment:
WIll it be null if we don't enable Netty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org