You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/11/21 00:02:58 UTC
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16758
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
IMPALA-10156: test_unmatched_schema should use unique_database
This updates the test to use the unique_database fixture instead
of trying to generate a unique table name on its own.
Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
---
M tests/query_test/test_scanners.py
1 file changed, 14 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/16758/1
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16758 )
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
IMPALA-10156: test_unmatched_schema should use unique_database
This updates the test to use the unique_database fixture instead
of trying to generate a unique table name on its own.
Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Reviewed-on: http://gerrit.cloudera.org:8080/16758
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 14 insertions(+), 18 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16758 )
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 Nov 2020 00:48:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16758 )
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7706/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 Nov 2020 00:24:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16758 )
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 Nov 2020 01:29:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16758 )
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6688/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 Nov 2020 01:29:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16758 )
Change subject: IMPALA-10156: test_unmatched_schema should use unique_database
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c5388d62f87795176b20243a4ccca70412b18c
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 Nov 2020 06:54:38 +0000
Gerrit-HasComments: No