You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Mike Drob <ma...@cloudera.com> on 2014/09/24 20:47:36 UTC
Thoughts on scaling back github integration
Devs,
Github integration is nice... but, I'm not a fan of how comments on diffs
are posted to the JIRAs. Each line note is a separate comment and it
includes a ton of irrelevant diff output. Looking at ACCUMULO-3089 is what
triggered this reaction for me.
Does anybody else have thoughts on this? I don't know what our integration
options are, but I would prefer something less intrusive. It's really easy
to lose the actual discussion with what we have now.
Mike
Re: Thoughts on scaling back github integration
Posted by Mike Drob <ma...@cloudera.com>.
I don't htink github is set up for issuing batches of comments, it's just
fire and forget. Maybe a PR could automatically show up on RB? I wonder how
much magic that would take...
On Wed, Sep 24, 2014 at 1:50 PM, Christopher <ct...@apache.org> wrote:
> I was thinking about this... and I was wondering if this is done by the ASF
> integration could batch these comments for mailing to the dev list and/or
> commenting on JIRA. I really like using GitHub for reviews/comments.
> Issuing pull requests is very seamless, but the comment activity is a bit
> annoying.
>
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
> On Wed, Sep 24, 2014 at 2:47 PM, Mike Drob <ma...@cloudera.com> wrote:
>
> > Devs,
> >
> > Github integration is nice... but, I'm not a fan of how comments on diffs
> > are posted to the JIRAs. Each line note is a separate comment and it
> > includes a ton of irrelevant diff output. Looking at ACCUMULO-3089 is
> what
> > triggered this reaction for me.
> >
> > Does anybody else have thoughts on this? I don't know what our
> integration
> > options are, but I would prefer something less intrusive. It's really
> easy
> > to lose the actual discussion with what we have now.
> >
> > Mike
> >
>
Re: Thoughts on scaling back github integration
Posted by Christopher <ct...@apache.org>.
I was thinking about this... and I was wondering if this is done by the ASF
integration could batch these comments for mailing to the dev list and/or
commenting on JIRA. I really like using GitHub for reviews/comments.
Issuing pull requests is very seamless, but the comment activity is a bit
annoying.
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Wed, Sep 24, 2014 at 2:47 PM, Mike Drob <ma...@cloudera.com> wrote:
> Devs,
>
> Github integration is nice... but, I'm not a fan of how comments on diffs
> are posted to the JIRAs. Each line note is a separate comment and it
> includes a ton of irrelevant diff output. Looking at ACCUMULO-3089 is what
> triggered this reaction for me.
>
> Does anybody else have thoughts on this? I don't know what our integration
> options are, but I would prefer something less intrusive. It's really easy
> to lose the actual discussion with what we have now.
>
> Mike
>
Re: Thoughts on scaling back github integration
Posted by Christopher <ct...@apache.org>.
Does worklog also get sent to the notifications list? That's probably okay.
I'd still like to seem them batched, if possible. GitHub is fire-and-forget
(unless RB, which batches, and you "publish"), but whatever ASF is doing to
capture these comments and copy them over, could presumably batch them
hourly, or at least every 15 minutes.
Another shortcoming I've seen is that no notification appears to be
generated when the pull request is updated.
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Wed, Sep 24, 2014 at 3:19 PM, Keith Turner <ke...@deenlo.com> wrote:
> Another options may be to have pull req coments to show up under worklog on
> issue, like commit messages do.
>
> On Wed, Sep 24, 2014 at 2:47 PM, Mike Drob <ma...@cloudera.com> wrote:
>
> > Devs,
> >
> > Github integration is nice... but, I'm not a fan of how comments on diffs
> > are posted to the JIRAs. Each line note is a separate comment and it
> > includes a ton of irrelevant diff output. Looking at ACCUMULO-3089 is
> what
> > triggered this reaction for me.
> >
> > Does anybody else have thoughts on this? I don't know what our
> integration
> > options are, but I would prefer something less intrusive. It's really
> easy
> > to lose the actual discussion with what we have now.
> >
> > Mike
> >
>
Re: Thoughts on scaling back github integration
Posted by Keith Turner <ke...@deenlo.com>.
Another options may be to have pull req coments to show up under worklog on
issue, like commit messages do.
On Wed, Sep 24, 2014 at 2:47 PM, Mike Drob <ma...@cloudera.com> wrote:
> Devs,
>
> Github integration is nice... but, I'm not a fan of how comments on diffs
> are posted to the JIRAs. Each line note is a separate comment and it
> includes a ton of irrelevant diff output. Looking at ACCUMULO-3089 is what
> triggered this reaction for me.
>
> Does anybody else have thoughts on this? I don't know what our integration
> options are, but I would prefer something less intrusive. It's really easy
> to lose the actual discussion with what we have now.
>
> Mike
>
Re: Thoughts on scaling back github integration
Posted by Keith Turner <ke...@deenlo.com>.
One option may be to not post review comment from github on issue, only on
dev list.
On Wed, Sep 24, 2014 at 2:47 PM, Mike Drob <ma...@cloudera.com> wrote:
> Devs,
>
> Github integration is nice... but, I'm not a fan of how comments on diffs
> are posted to the JIRAs. Each line note is a separate comment and it
> includes a ton of irrelevant diff output. Looking at ACCUMULO-3089 is what
> triggered this reaction for me.
>
> Does anybody else have thoughts on this? I don't know what our integration
> options are, but I would prefer something less intrusive. It's really easy
> to lose the actual discussion with what we have now.
>
> Mike
>