You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/02/03 10:23:24 UTC

[GitHub] [libcloud] r2ronoha opened a new pull request #1656: Add support for eu-south-1 in EC2

r2ronoha opened a new pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656


   ## Changes Title (replace this with a logical title for your changes)
   
   ### Description
   
   Replace this with the PR description (mention the changes you have made, why
   you have made them, provide some background and any references to the provider
   documentation if needed, etc.).
   
   For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
   section of our documentation.
   
   ### Status
   
   Replace this: describe the PR status. Examples:
   
   - work in progress
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [] Documentation
   - [] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] r2ronoha commented on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
r2ronoha commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028955444


   > @r2ronoha There is a signature one - https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_ec2.py#L112. We don't have it for every single region, but it's not a bad idea to add it when adding a new region.
   
   added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] codecov-commenter commented on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028891650


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1656](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f6754e) into [trunk](https://codecov.io/gh/apache/libcloud/commit/39ae29367fe24f8ac216111fe762cd0f96cce541?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39ae293) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 0f6754e differs from pull request most recent head 9bbc04b. Consider uploading reports for the commit 9bbc04b to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1656/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1656   +/-   ##
   =======================================
     Coverage   83.19%   83.19%           
   =======================================
     Files         400      400           
     Lines       86853    86853           
     Branches     9227     9227           
   =======================================
     Hits        72254    72254           
     Misses      11460    11460           
     Partials     3139     3139           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/constants/ec2\_instance\_types.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
   | [...d/compute/constants/ec2\_region\_details\_complete.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
   | [...ud/compute/constants/ec2\_region\_details\_partial.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX3BhcnRpYWwucHk=) | `100.00% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [39ae293...9bbc04b](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on a change in pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#discussion_r818968027



##########
File path: libcloud/compute/drivers/vcloud.py
##########
@@ -1069,11 +1069,11 @@ class VCloud_5_5_Connection(VCloud_1_5_Connection):
     def _get_auth_headers(self):
         """Compatibility for using v5.5 of the API"""
         auth_headers = super(VCloud_5_5_Connection, self)._get_auth_headers()
-        auth_headers["Accept"] = "application/*+xml;version=5.5"
+        auth_headers["Accept"] = 'application/*;version=32.0'

Review comment:
       If the change was intention, please open a separate PR for that change and please also include more information / background - why is that change needed, some references, etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] r2ronoha commented on pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
r2ronoha commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1037180141


   /test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028891650


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1656](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ee6a78) into [trunk](https://codecov.io/gh/apache/libcloud/commit/39ae29367fe24f8ac216111fe762cd0f96cce541?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39ae293) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1656/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1656   +/-   ##
   =======================================
     Coverage   83.19%   83.19%           
   =======================================
     Files         400      400           
     Lines       86853    86855    +2     
     Branches     9227     9227           
   =======================================
   + Hits        72254    72256    +2     
     Misses      11460    11460           
     Partials     3139     3139           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/constants/ec2\_instance\_types.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
   | [...d/compute/constants/ec2\_region\_details\_complete.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
   | [...ud/compute/constants/ec2\_region\_details\_partial.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX3BhcnRpYWwucHk=) | `100.00% <ø> (ø)` | |
   | [libcloud/test/compute/test\_ec2.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZWMyLnB5) | `97.90% <100.00%> (+<0.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [39ae293...3ee6a78](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] r2ronoha commented on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
r2ronoha commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028910005


   > Thanks for the contribution.
   > 
   > Can you please also add / update existing test cases?
   
   I don't think there are specific tests fo single ec2 region additions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] r2ronoha commented on a change in pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
r2ronoha commented on a change in pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#discussion_r818603293



##########
File path: libcloud/compute/drivers/vcloud.py
##########
@@ -1069,11 +1069,11 @@ class VCloud_5_5_Connection(VCloud_1_5_Connection):
     def _get_auth_headers(self):
         """Compatibility for using v5.5 of the API"""
         auth_headers = super(VCloud_5_5_Connection, self)._get_auth_headers()
-        auth_headers["Accept"] = "application/*+xml;version=5.5"
+        auth_headers["Accept"] = 'application/*;version=32.0'

Review comment:
       it was intentional




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami merged pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1057399084


   Fixed failing tests and checks, re-scraped and re-generated pricing and sizing data and merged changes into trunk.
   
   Thanks for the contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on a change in pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#discussion_r818086298



##########
File path: libcloud/compute/drivers/vcloud.py
##########
@@ -1069,11 +1069,11 @@ class VCloud_5_5_Connection(VCloud_1_5_Connection):
     def _get_auth_headers(self):
         """Compatibility for using v5.5 of the API"""
         auth_headers = super(VCloud_5_5_Connection, self)._get_auth_headers()
-        auth_headers["Accept"] = "application/*+xml;version=5.5"
+        auth_headers["Accept"] = 'application/*;version=32.0'

Review comment:
       For now, to get the tests pass I will revert this change + change to the tests, but if this change is needed, please open a separate PR for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on a change in pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#discussion_r818968027



##########
File path: libcloud/compute/drivers/vcloud.py
##########
@@ -1069,11 +1069,11 @@ class VCloud_5_5_Connection(VCloud_1_5_Connection):
     def _get_auth_headers(self):
         """Compatibility for using v5.5 of the API"""
         auth_headers = super(VCloud_5_5_Connection, self)._get_auth_headers()
-        auth_headers["Accept"] = "application/*+xml;version=5.5"
+        auth_headers["Accept"] = 'application/*;version=32.0'

Review comment:
       If the change was intentional, please open a separate PR for that change and please also include more information / background - why is that change needed, some references, etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028891650


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1656](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf324a6) into [trunk](https://codecov.io/gh/apache/libcloud/commit/39ae29367fe24f8ac216111fe762cd0f96cce541?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39ae293) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head bf324a6 differs from pull request most recent head 9bbc04b. Consider uploading reports for the commit 9bbc04b to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1656/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1656   +/-   ##
   =======================================
     Coverage   83.19%   83.19%           
   =======================================
     Files         400      400           
     Lines       86853    86853           
     Branches     9227     9227           
   =======================================
     Hits        72254    72254           
     Misses      11460    11460           
     Partials     3139     3139           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/constants/ec2\_instance\_types.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
   | [...d/compute/constants/ec2\_region\_details\_complete.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
   | [...ud/compute/constants/ec2\_region\_details\_partial.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX3BhcnRpYWwucHk=) | `100.00% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [39ae293...9bbc04b](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028891650


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1656](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9bbc04b) into [trunk](https://codecov.io/gh/apache/libcloud/commit/39ae29367fe24f8ac216111fe762cd0f96cce541?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39ae293) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1656/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1656   +/-   ##
   =======================================
     Coverage   83.19%   83.19%           
   =======================================
     Files         400      400           
     Lines       86853    86853           
     Branches     9227     9227           
   =======================================
     Hits        72254    72254           
     Misses      11460    11460           
     Partials     3139     3139           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/constants/ec2\_instance\_types.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX2luc3RhbmNlX3R5cGVzLnB5) | `100.00% <ø> (ø)` | |
   | [...d/compute/constants/ec2\_region\_details\_complete.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX2NvbXBsZXRlLnB5) | `100.00% <ø> (ø)` | |
   | [...ud/compute/constants/ec2\_region\_details\_partial.py](https://codecov.io/gh/apache/libcloud/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9jb25zdGFudHMvZWMyX3JlZ2lvbl9kZXRhaWxzX3BhcnRpYWwucHk=) | `100.00% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [39ae293...9bbc04b](https://codecov.io/gh/apache/libcloud/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] r2ronoha commented on pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
r2ronoha commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1037180141


   /test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028907136


   Thanks for the contribution.
   
   Can you please also add / update existing test cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on pull request #1656: Add support for eu-south-1 in EC2

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1028920597


   @r2ronoha There is a signature one - https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_ec2.py#L112. We don't have it for every single region, but it's not a bad idea to add it when adding a new region.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1057354000


   It looks like a unit test is failing and a bunch of lint checks are also failing:
   
   ```bash
   libcloud/compute/constants/ec2_instance_types.py:2706:5: F601 dictionary key 'c6i.12xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2740:5: F601 dictionary key 'c6i.16xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2775:5: F601 dictionary key 'c6i.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2810:5: F601 dictionary key 'c6i.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2845:5: F601 dictionary key 'c6i.32xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2879:5: F601 dictionary key 'c6i.4xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2914:5: F601 dictionary key 'c6i.8xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2948:5: F601 dictionary key 'c6i.large' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2982:5: F601 dictionary key 'c6i.xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3017:5: F601 dictionary key 'c6i.12xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3052:5: F601 dictionary key 'c6i.16xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3087:5: F601 dictionary key 'c6i.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3122:5: F601 dictionary key 'c6i.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3157:5: F601 dictionary key 'c6i.32xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3192:5: F601 dictionary key 'c6i.4xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3227:5: F601 dictionary key 'c6i.8xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3261:5: F601 dictionary key 'c6i.large' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3295:5: F601 dictionary key 'c6i.xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3874:5: F601 dictionary key 'dl1.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3908:5: F601 dictionary key 'dl1.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4292:5: F601 dictionary key 'g4ad.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4327:5: F601 dictionary key 'g4ad.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4434:5: F601 dictionary key 'g4ad.xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4469:5: F601 dictionary key 'g4ad.xlarge' repeated with different values
   ```
   
   I will try to get that sorted out and merge the PR into trunk. Thanks for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on a change in pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#discussion_r818082456



##########
File path: libcloud/compute/drivers/vcloud.py
##########
@@ -1069,11 +1069,11 @@ class VCloud_5_5_Connection(VCloud_1_5_Connection):
     def _get_auth_headers(self):
         """Compatibility for using v5.5 of the API"""
         auth_headers = super(VCloud_5_5_Connection, self)._get_auth_headers()
-        auth_headers["Accept"] = "application/*+xml;version=5.5"
+        auth_headers["Accept"] = 'application/*;version=32.0'

Review comment:
       Was that change intentional? Since it looks like test case is now failing with this change - https://github.com/apache/libcloud/runs/5153389792?check_suite_focus=true#step:11:20321.
   
   If it's not intentional, I will revert it so the tests pass and I can merge the PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org