You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/22 23:57:18 UTC

[jira] [Commented] (DISPATCH-223) Unknown connector name is not properly printed in error messages

    [ https://issues.apache.org/jira/browse/DISPATCH-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157886#comment-15157886 ] 

ASF GitHub Bot commented on DISPATCH-223:
-----------------------------------------

GitHub user scholzj opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/48

    DISPATCH-223 Prepare the error message before freeing the resources

    Preparing the error message before freeing the connector creates the correct error message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scholzj/qpid-dispatch DISPATCH-223

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit daabe01ebb7e6bc26838c74bd2f9a758782fb59c
Author: Jakub Scholz <ww...@scholzj.com>
Date:   2016-02-22T22:50:23Z

    DISPATCH-223 Prepare the error message before freeing the resources

----


> Unknown connector name is not properly printed in error messages
> ----------------------------------------------------------------
>
>                 Key: DISPATCH-223
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-223
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Jakub Scholz
>            Priority: Minor
>
> When I try to start dispatch router with a link route configured for unknown connector (or a connector with a wrong type), the error message contains memory garbage instead of the container name, because the container name has been already freed before formatting the message.
> Mon Feb 22 17:24:46 2016 SERVER (info) Container Name: Qpid.Dispatch.Router.A
> Mon Feb 22 17:24:46 2016 ROUTER (info) Router started in Standalone mode
> Mon Feb 22 17:24:46 2016 AGENT (info) Activating management agent on $management
> Mon Feb 22 17:24:46 2016 ROUTER (info) In-Process Address Registered: $management
> Mon Feb 22 17:24:46 2016 ROUTER (info) In-Process Address Registered: $management
> Mon Feb 22 17:24:46 2016 CONN_MGR (info) Configured Listener: 0.0.0.0:amqp proto=any role=normal
> Mon Feb 22 17:24:46 2016 CONN_MGR (info) Configured Listener: 0.0.0.0:5671 proto=any role=normal
> Mon Feb 22 17:24:46 2016 CONN_MGR (info) Configured on-demand connector: 10.0.2.2:11234 name=user1Connector
> Mon Feb 22 17:24:46 2016 CONN_MGR (info) Configured Connector: gw:11234 proto=any role=normal
> Mon Feb 22 17:24:46 2016 ERROR (error) Configuration: Link-route-pattern configured with unknown connector: �
> Mon Feb 22 17:24:46 2016 ERROR (error) Python: CError: Configuration: Link-route-pattern configured with unknown connector: �
> Mon Feb 22 17:24:46 2016 ERROR (error) Traceback (most recent call last):
>   File "/usr/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py", line 153, in configure_dispatch
>     for a in config.by_type(t): configure(a)
>   File "/usr/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py", line 134, in configure
>     agent.configure(attributes)
>   File "/usr/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py", line 770, in configure
>     self._create(attributes)
>   File "/usr/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py", line 743, in _create
>     entity.create()
>   File "/usr/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py", line 329, in create
>     self._qd.qd_dispatch_configure_lrp(self._dispatch, self)
>   File "/usr/local/lib/qpid-dispatch/python/qpid_dispatch_internal/dispatch.py", line 83, in _errcheck
>     raise CError(self.qd_error_message())
> CError: Configuration: Link-route-pattern configured with unknown connector: �
> Mon Feb 22 17:24:46 2016 MAIN (critical) Router start-up failed: Python: CError: Configuration: Link-route-pattern configured with unknown connector: �
> qdrouterd: Python: CError: Configuration: Link-route-pattern configured with unknown connector: �



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org