[GitHub] [hudi] YannByron commented on a diff in pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

["YannByron (via GitHub)" <gi...@apache.org>]

YannByron commented on code in PR #7849:
URL: https://github.com/apache/hudi/pull/7849#discussion_r1096562129


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -80,21 +80,11 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
       TaskContextSupplier taskContextSupplier,
       Option<BaseKeyGenerator> keyGeneratorOpt) {
     if (table.requireSortedRecords()) {
-      if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
-        return new HoodieSortedMergeHandleWithChangeLog<>(writeConfig, instantTime, table, keyToNewRecords, partitionPath, fileId,
-            dataFileToBeMerged, taskContextSupplier, keyGeneratorOpt);

Review Comment:
   why claim the MOR table CDC is not supported?  This pr works.
   And the previous method name is not easy to distinguish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org