[GitHub] [arrow-datafusion] mingmwang commented on pull request #1924: Refactor ExecutionContext and related conf to support multi-tenancy configurations

[GitBox <gi...@apache.org>]

mingmwang commented on pull request #1924:
URL: https://github.com/apache/arrow-datafusion/pull/1924#issuecomment-1060278909


   I think the debate is whether we should have a global RuntimeEnv for DataFusion. Originally the RuntimeEnv was not a singleton. But I would say the definition of RuntimeEnv was not clear . It stood for an 
   execution runtime environment and the structure was passed to the physical plans when they are run. Looks like It was the task/physical plan's runtime. But the original ExecutionContextState also had a member of type RuntimeEnv(not a reference), so the RuntimeEnv also stood for DataFusion/Ballista context's runtime. So does it stand for a task level runtime or session/execution context level runtime is not clear.  RuntimeEnv was originally introduced for MemoryManager and DiskManager which I think should be managed globally.  After this refactoring, I think the meaning of RuntimeEnv is more clear.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org