[jira] [Commented] (HBASE-24581) Skip compaction request/check for replica regions at the early stage.

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158118#comment-17158118 ] 

Hudson commented on HBASE-24581:
--------------------------------

Results for branch master
	[build #1786 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1786/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1786/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1786/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1786/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Skip compaction request/check for replica regions at the early stage.
> ---------------------------------------------------------------------
>
>                 Key: HBASE-24581
>                 URL: https://issues.apache.org/jira/browse/HBASE-24581
>             Project: HBase
>          Issue Type: Improvement
>          Components: read replicas
>    Affects Versions: 2.3.0
>            Reporter: Huaxiang Sun
>            Assignee: Huaxiang Sun
>            Priority: Major
>
> I found that in certain cases replica regions can trigger compaction, one example as follows, need to check all places to avoid compaction for replica regions.
> {code:java}
> @Override
> public void postOpenDeployTasks(final PostOpenDeployContext context) throws IOException {
>   HRegion r = context.getRegion();
>   long openProcId = context.getOpenProcId();
>   long masterSystemTime = context.getMasterSystemTime();
>   rpcServices.checkOpen();
>   LOG.info("Post open deploy tasks for {}, openProcId={}, masterSystemTime={}",
>     r.getRegionInfo().getRegionNameAsString(), openProcId, masterSystemTime);
>   // Do checks to see if we need to compact (references or too many files)
>   // TODO: SHX, do not do this for replica regions? Otherwise, it is going to lost data locality for primary regions.
>   for (HStore s : r.stores.values()) {
>     if (s.hasReferences() || s.needsCompaction()) {
>       this.compactSplitThread.requestSystemCompaction(r, s, "Opening Region");
>     }
>   }
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)