You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/01 20:55:25 UTC
[GitHub] [pinot] 61yao opened a new pull request, #9322: [Feature] Support boolean literals equals and notEquals
61yao opened a new pull request, #9322:
URL: https://github.com/apache/pinot/pull/9322
Support boolean literal evaluation, eg. true = true, (true = true) != false
1) Save literal value as an object
2) Register scalar function with func names and argument types. If a function cannot be found via function function names and argument types, look for functions through func names and # of params by default.
3) Currently, we only support equal and notEqual type matching for boolean and double.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] 61yao commented on pull request #9322: [Feature] Support boolean literals equals and notEquals
Posted by GitBox <gi...@apache.org>.
61yao commented on PR #9322:
URL: https://github.com/apache/pinot/pull/9322#issuecomment-1238671107
> This might not be the best way to support literal equations let's first straighten out the target:
>
> ## do we want to support this on transform or predicate
> I think let's focus on transform functions. in this case I think the missing piece is to add literal handling to `binaryoperatortransformfunction` on both side
>
> ## do we want to do typed equal / not-equal check
> let's only do non-typed check. b/c typed solution will be very complex: see #8596
>
> with the basic solution in we can focus on #8596 to actually make the literals typed.
I am not sure if I fully understand about your point on literal support for binaryTransform. Shouldn't two literal eval fall into scalar function by default?
Or you meant expressions like SELECT <BOOL_EXPR> = TRUE ? this is already supported.
I am not against using proposal https://github.com/apache/pinot/issues/8596 depending on the priority. This PR is hacky and expensive. but I feel it is not worse than the implementation we already have right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] 61yao commented on pull request #9322: [Feature] Support boolean literals equals and notEquals
Posted by GitBox <gi...@apache.org>.
61yao commented on PR #9322:
URL: https://github.com/apache/pinot/pull/9322#issuecomment-1242653279
Discussed offline. Since this is not urgent, I'll do some refactoring first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] 61yao closed pull request #9322: [Feature] Support boolean literals equals and notEquals
Posted by GitBox <gi...@apache.org>.
61yao closed pull request #9322: [Feature] Support boolean literals equals and notEquals
URL: https://github.com/apache/pinot/pull/9322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org