You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/22 20:36:53 UTC
Review Request 38639: Add os::clone function in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Cong Wang.
Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474
Repository: mesos
Description
-------
Add os::clone function in stout.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
Diff: https://reviews.apache.org/r/38639/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 38639: Add os::clone function in stout.
Posted by Cong Wang <cw...@twopensource.com>.
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
>
> haosdent huang wrote:
> Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
>
> Cong Wang wrote:
> I meant:
>
> clone(...int flags, int signal)
> {
> ::clone(... flags | siganl, ...);
> }
>
> haosdent huang wrote:
> Got it, let me change to that.
>
> Jie Yu wrote:
> I suggest keeping 'flags' for now because 'clone' takes an or'ed flags.
>
> haosdent huang wrote:
> Oh, got it. #_#
Why flags can't be or'ed with my suggested implementation? You can still do clone(... CLONE_VM|CLONE_NET, SIGCHLD).
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Cong Wang <cw...@twopensource.com>.
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
>
> haosdent huang wrote:
> Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
I meant:
clone(...int flags, int signal)
{
::clone(... flags | siganl, ...);
}
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
>
> haosdent huang wrote:
> Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
>
> Cong Wang wrote:
> I meant:
>
> clone(...int flags, int signal)
> {
> ::clone(... flags | siganl, ...);
> }
>
> haosdent huang wrote:
> Got it, let me change to that.
>
> Jie Yu wrote:
> I suggest keeping 'flags' for now because 'clone' takes an or'ed flags.
Oh, got it. #_#
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
>
> haosdent huang wrote:
> Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
>
> Cong Wang wrote:
> I meant:
>
> clone(...int flags, int signal)
> {
> ::clone(... flags | siganl, ...);
> }
>
> haosdent huang wrote:
> Got it, let me change to that.
I suggest keeping 'flags' for now because 'clone' takes an or'ed flags.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
>
> haosdent huang wrote:
> Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
>
> Cong Wang wrote:
> I meant:
>
> clone(...int flags, int signal)
> {
> ::clone(... flags | siganl, ...);
> }
Got it, let me change to that.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 52)
<https://reviews.apache.org/r/38639/#comment157134>
s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better, pass namespaces separately with signals as two different parameters?
- Cong Wang
On Sept. 22, 2015, 6:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line73>
> >
> > We should delete the stack only if CLONE_VM was not specified in the flags or at least have a comment mentioning the fact that this call is creating a new process and not a new thread. Having a CLONE_VM will create a new thread, not a new process.
>
> Jie Yu wrote:
> Good call! +1
Or we can disallow CLONE_VM since if the user wants to create a thread, he/she should use pthread.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100046
-----------------------------------------------------------
On Sept. 22, 2015, 6:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line73>
> >
> > We should delete the stack only if CLONE_VM was not specified in the flags or at least have a comment mentioning the fact that this call is creating a new process and not a new thread. Having a CLONE_VM will create a new thread, not a new process.
Good call! +1
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100046
-----------------------------------------------------------
On Sept. 22, 2015, 6:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Sept. 22, 2015, 2:58 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line73>
> >
> > We should delete the stack only if CLONE_VM was not specified in the flags or at least have a comment mentioning the fact that this call is creating a new process and not a new thread. Having a CLONE_VM will create a new thread, not a new process.
>
> Jie Yu wrote:
> Good call! +1
>
> Jie Yu wrote:
> Or we can disallow CLONE_VM since if the user wants to create a thread, he/she should use pthread.
That should work too and is better in my opinion.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100046
-----------------------------------------------------------
On Sept. 22, 2015, 2:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line73>
> >
> > We should delete the stack only if CLONE_VM was not specified in the flags or at least have a comment mentioning the fact that this call is creating a new process and not a new thread. Having a CLONE_VM will create a new thread, not a new process.
>
> Jie Yu wrote:
> Good call! +1
>
> Jie Yu wrote:
> Or we can disallow CLONE_VM since if the user wants to create a thread, he/she should use pthread.
>
> Kapil Arya wrote:
> That should work too and is better in my opinion.
Thanks a lot!
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100046
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100046
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 73)
<https://reviews.apache.org/r/38639/#comment157135>
We should delete the stack only if CLONE_VM was not specified in the flags or at least have a comment mentioning the fact that this call is creating a new process and not a new thread. Having a CLONE_VM will create a new thread, not a new process.
- Kapil Arya
On Sept. 22, 2015, 2:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 23, 2015, 5:43 a.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 138
> > <https://reviews.apache.org/r/38639/diff/2/?file=1081863#file1081863line138>
> >
> > This whitespace change is not supposed in this patch.
I'll commit this one for now. Next time, it's better to split unrelated changes.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100139
-----------------------------------------------------------
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100139
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 138)
<https://reviews.apache.org/r/38639/#comment157286>
This whitespace change is not supposed in this patch.
- Cong Wang
On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 1:26 a.m.)
Review request for mesos, Jie Yu and Cong Wang.
Changes
-------
Update according reviews.
Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474
Repository: mesos
Description
-------
Add os::clone function in stout.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
Diff: https://reviews.apache.org/r/38639/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 38639: Add os::clone function in stout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100042
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 52)
<https://reviews.apache.org/r/38639/#comment157131>
in fact, can you rename 'namespaces' to 'flags'?
- Jie Yu
On Sept. 22, 2015, 6:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38639: Add os::clone function in stout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100039
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 22, 2015, 6:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Cong Wang.
>
>
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add os::clone function in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd
>
> Diff: https://reviews.apache.org/r/38639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>