You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/10 18:48:12 UTC
[jira] [Commented] (CB-8397) Add support to 'windows' for showing
the Windows Phone splashscreen
[ https://issues.apache.org/jira/browse/CB-8397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314520#comment-14314520 ]
ASF GitHub Bot commented on CB-8397:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/35
CB-8397 Add support for Windows Phone 8.1 splashscreen
https://issues.apache.org/jira/browse/CB-8397
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8397
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit b3ca556a3d29a15f01e24fd0e7c5c6c24420e93e
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-02-06T15:15:08Z
CB-8397 Add support to 'windows' for showing the Windows Phone splashscreen
----
> Add support to 'windows' for showing the Windows Phone splashscreen
> -------------------------------------------------------------------
>
> Key: CB-8397
> URL: https://issues.apache.org/jira/browse/CB-8397
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova-plugin-splash-screen, windows, windows-phone-81
>
> 1. Incorrect image is used on Windows Phone 8.1 (SplashScreen instead of SplashScreenPhone)
> 2. Image is not correctly centered: this is due to source currently used is based on the following sample which requires splash screen to be under (data-win-control="WinJS.UI.ViewBox", requires WinJS.../.. ui.js)
> https://code.msdn.microsoft.com/windowsapps/Splash-screen-sample-89c1dc78
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org