You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "yirutang (via GitHub)" <gi...@apache.org> on 2025/05/09 23:50:42 UTC

[PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

yirutang opened a new pull request, #34909:
URL: https://github.com/apache/beam/pull/34909

   …tion method.
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #34909:
URL: https://github.com/apache/beam/pull/34909#discussion_r2082671293


##########
website/www/site/content/en/documentation/io/built-in/google-bigquery.md:
##########
@@ -667,38 +667,30 @@ You can set `with_auto_sharding=True` to enable dynamic sharding (starting
 The sharding behavior depends on the runners.
 {{< /paragraph >}}
 
-BigQueryIO uses streaming inserts in the following situations:
+BigQueryIO uses Write API in the following situations:
 
 {{< paragraph class="language-java" wrap="span" >}}
 * When you apply a BigQueryIO write transform to an unbounded `PCollection`.
-* When you specify streaming inserts as the insertion method using
-  `BigQueryIO.write().withMethod(STREAMING_INSERTS)`.
+* When you specify Write API as the ingestion method using

Review Comment:
   cc @ahmedabu98 @Abacn 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #34909:
URL: https://github.com/apache/beam/pull/34909#discussion_r2145113809


##########
website/www/site/content/en/documentation/io/built-in/google-bigquery.md:
##########
@@ -667,38 +667,30 @@ You can set `with_auto_sharding=True` to enable dynamic sharding (starting
 The sharding behavior depends on the runners.
 {{< /paragraph >}}
 
-BigQueryIO uses streaming inserts in the following situations:
+BigQueryIO uses Write API in the following situations:
 
 {{< paragraph class="language-java" wrap="span" >}}
 * When you apply a BigQueryIO write transform to an unbounded `PCollection`.
-* When you specify streaming inserts as the insertion method using
-  `BigQueryIO.write().withMethod(STREAMING_INSERTS)`.
+* When you specify Write API as the ingestion method using

Review Comment:
   +1 - maybe we could describe this in a clear `Legacy:` section so it is obviously not recommended, but we still have the troubleshooting info



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2930398208

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles for label website.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2916083018

   Reminder, please take a look at this pr: @melap 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2888346904

   Reminder, please take a look at this pr: @rszper 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2970422278

   waiting on author


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-3371462088

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2868205597

   Assigning reviewers:
   
   R: @rszper for label website.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-3397390200

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "yirutang (via GitHub)" <gi...@apache.org>.
yirutang commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2868127883

   In theory, they don't need to use it. And there are no other places
   documented INSERT method. Is this only place alone enough?
   
   On Fri, May 9, 2025 at 5:06 PM liferoad ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > website/www/site/content/en/documentation/io/built-in/google-bigquery.md
   > <https://github.com/apache/beam/pull/34909#discussion_r2082671293>:
   >
   > >
   >  {{< paragraph class="language-java" wrap="span" >}}
   >  * When you apply a BigQueryIO write transform to an unbounded `PCollection`.
   > -* When you specify streaming inserts as the insertion method using
   > -  `BigQueryIO.write().withMethod(STREAMING_INSERTS)`.
   > +* When you specify Write API as the ingestion method using
   >
   > cc @ahmedabu98 <https://github.com/ahmedabu98> @Abacn
   > <https://github.com/Abacn>
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/34909#discussion_r2082671293>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AHGYVEWVKRL3QCJIJVOQEYL25U7GXAVCNFSM6AAAAAB42FAPB2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRZHE2TENBTGQ>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   
   
   -- 
   Thanks.
   
   Yiru
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #34909:
URL: https://github.com/apache/beam/pull/34909#discussion_r2082670433


##########
website/www/site/content/en/documentation/io/built-in/google-bigquery.md:
##########
@@ -667,38 +667,30 @@ You can set `with_auto_sharding=True` to enable dynamic sharding (starting
 The sharding behavior depends on the runners.
 {{< /paragraph >}}
 
-BigQueryIO uses streaming inserts in the following situations:
+BigQueryIO uses Write API in the following situations:
 
 {{< paragraph class="language-java" wrap="span" >}}
 * When you apply a BigQueryIO write transform to an unbounded `PCollection`.
-* When you specify streaming inserts as the insertion method using
-  `BigQueryIO.write().withMethod(STREAMING_INSERTS)`.
+* When you specify Write API as the ingestion method using

Review Comment:
   shall we still keep the docs for Streaming_Inserts given it is still used a lot? we can mention `STORAGE_API_AT_LEAST_ONCE` is recommended for sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-3161071600

   waiting on author


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2958979671

   Reminder, please take a look at this pr: @kennknowles 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2970209150

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label website.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34909:
URL: https://github.com/apache/beam/pull/34909#issuecomment-2897736398

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @melap for label website.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update google-bigquery.md to direct to Storage Write API as the inges… [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34909: Update google-bigquery.md to direct to Storage Write API as the inges…
URL: https://github.com/apache/beam/pull/34909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org