[GitHub] zhanghang1989 commented on a change in pull request #10303: [MXNET-246] operators for Synchronized BatchNorm

[GitBox <gi...@apache.org>]

zhanghang1989 commented on a change in pull request #10303: [MXNET-246] operators for Synchronized BatchNorm
URL: https://github.com/apache/incubator-mxnet/pull/10303#discussion_r177904669
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -164,7 +164,12 @@ inline void SetShapeType(const Context& ctx,
     NDArrayStorageType storage_type = static_cast<NDArrayStorageType>(out_storage_types[i]);
     if (outputs[i]->is_none()) {
       if (storage_type == kDefaultStorage) {
-        *outputs[i] = NDArray(out_shapes[i], ctx, true, out_types[i]);
+        if (outputs.size() == inputs.size()) {
 
 Review comment:
   This is for AllReduce operator, the outputs should be in the same device as the corresponding input.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services