You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/02/02 06:28:45 UTC

[GitHub] [systemds] j143 commented on pull request #1531: [SYSTEMDS-2996] countDistinctApprox Builtin function

j143 commented on pull request #1531:
URL: https://github.com/apache/systemds/pull/1531#issuecomment-1027627334


   Hi @BACtaki - I have cursorily reviewed the PR.
   1. Is it possible to add java docs to the class, there are java doc warnings.
   2. Make sure the .dml files are available for the test class (CI tests are failing for that reason).
   
   
   The PR will be deep reviewed by code owners of this feature, perhaps Sebastian!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org