You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/20 12:25:49 UTC
[GitHub] [beam] runningcode opened a new pull request #13148: Bump Gradle to 6.7
runningcode opened a new pull request #13148:
URL: https://github.com/apache/beam/pull/13148
Also bump Avro plugin version and dependencies plugin
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-725068314
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r521535050
##########
File path: gradle.properties
##########
@@ -19,6 +19,7 @@ org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xss10240k
+org.gradle.vfs.watch=true
Review comment:
Ok I'm fine with keeping it, it's easy enough to revert in the unlikely case it does end up causing issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
runningcode commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r521175233
##########
File path: gradle.properties
##########
@@ -19,6 +19,7 @@ org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xss10240k
+org.gradle.vfs.watch=true
Review comment:
I trust the Gradle team when they say that it is ready for production use. They use it themselves in the Gradle build: https://github.com/gradle/gradle/blob/master/gradle.properties#L14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-725030635
Looks like Java PreCommit is broken at head atm, not due to this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
runningcode commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-724993271
Thanks. I updated the description and also included the filewatching in the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-725567368
Run Java_Examples_Dataflow PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
runningcode commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r521174591
##########
File path: buildSrc/build.gradle
##########
@@ -44,7 +44,7 @@ dependencies {
runtime "com.google.protobuf:protobuf-gradle-plugin:0.8.13" // Enable proto code generation
runtime "io.spring.gradle:propdeps-plugin:0.0.9.RELEASE" // Enable provided and optional configurations
runtime "com.commercehub.gradle.plugin:gradle-avro-plugin:0.11.0" // Enable Avro code generation
- runtime "com.diffplug.spotless:spotless-plugin-gradle:5.1.2" // Enable a code formatting plugin
+ runtime "com.diffplug.spotless:spotless-plugin-gradle:5.6.0" // Enable a code formatting plugin
Review comment:
Done! thanks for pointing this out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r520891393
##########
File path: gradle/wrapper/gradle-wrapper.properties
##########
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-bin.zip
Review comment:
Is there a reason we were using -all before? AFAICT it looks like the difference is -all includes docs and source code, which we should be fine without
##########
File path: gradle.properties
##########
@@ -19,6 +19,7 @@ org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xss10240k
+org.gradle.vfs.watch=true
Review comment:
I'm a little wary of this. The [blog post](https://blog.gradle.org/introducing-file-system-watching) does say its ready for production use... but I'm wondering if we should just let individuals try it themselves until it's enabled by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
runningcode commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r521175233
##########
File path: gradle.properties
##########
@@ -19,6 +19,7 @@ org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xss10240k
+org.gradle.vfs.watch=true
Review comment:
I trust the Gradle team when they say that it is ready for production use. They use it themselves in the Gradle build: https://github.com/gradle/gradle/blob/master/gradle.properties#L14
Happy to remove it if you feel it isn't safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r520938993
##########
File path: buildSrc/build.gradle
##########
@@ -44,7 +44,7 @@ dependencies {
runtime "com.google.protobuf:protobuf-gradle-plugin:0.8.13" // Enable proto code generation
runtime "io.spring.gradle:propdeps-plugin:0.0.9.RELEASE" // Enable provided and optional configurations
runtime "com.commercehub.gradle.plugin:gradle-avro-plugin:0.11.0" // Enable Avro code generation
- runtime "com.diffplug.spotless:spotless-plugin-gradle:5.1.2" // Enable a code formatting plugin
+ runtime "com.diffplug.spotless:spotless-plugin-gradle:5.6.0" // Enable a code formatting plugin
Review comment:
Sorry for the piecemeal review.. one more comment, it looks like there's a 5.6.1 bugfix release, can we go ahead and bump to that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-724972473
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #13148:
URL: https://github.com/apache/beam/pull/13148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-724975438
> Also bump Avro plugin version and dependencies plugin
I think you meant spotless plugin? I don't see a change to avro. Also looks like this enables [file system watching](https://blog.gradle.org/introducing-file-system-watching) by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r520908725
##########
File path: buildSrc/build.gradle
##########
@@ -44,7 +44,7 @@ dependencies {
runtime "com.google.protobuf:protobuf-gradle-plugin:0.8.13" // Enable proto code generation
runtime "io.spring.gradle:propdeps-plugin:0.0.9.RELEASE" // Enable provided and optional configurations
runtime "com.commercehub.gradle.plugin:gradle-avro-plugin:0.11.0" // Enable Avro code generation
- runtime "com.diffplug.spotless:spotless-plugin-gradle:5.1.2" // Enable a code formatting plugin
+ runtime "com.diffplug.spotless:spotless-plugin-gradle:5.6.0" // Enable a code formatting plugin
Review comment:
It looks like the spotless plugin version is also referenced in `plugins { }` above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on a change in pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
runningcode commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r521175573
##########
File path: gradle/wrapper/gradle-wrapper.properties
##########
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-bin.zip
Review comment:
I reverted this just to keep it the same. `-bin` is a significantly smaller download.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
runningcode commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-724134373
R: @TheNeuralBit R: @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13148: Bump Gradle to 6.7
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13148:
URL: https://github.com/apache/beam/pull/13148#issuecomment-725000994
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org