You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/11/17 05:01:38 UTC
[GitHub] asdf2014 commented on a change in pull request #6637:
FilteredRequestLogger: Fix start/stop, invalid delegate behavior.
asdf2014 commented on a change in pull request #6637: FilteredRequestLogger: Fix start/stop, invalid delegate behavior.
URL: https://github.com/apache/incubator-druid/pull/6637#discussion_r234396944
##########
File path: core/src/main/java/org/apache/druid/guice/JsonConfigProvider.java
##########
@@ -134,6 +153,20 @@
binder.bind(instanceKey).toProvider(new SupplierProvider<>(supplierKey));
}
+ @SuppressWarnings("unchecked")
Review comment:
This `unchecked` annotation is useless. FYI, the same issues occurs in line [#143](https://github.com/apache/incubator-druid/pull/6637/files#diff-02fb611063c0b7ecec0bba4ad5f468fbR143). Maybe we should remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org