[GitHub] [spark] kotlovs commented on a change in pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method

[GitBox <gi...@apache.org>]

kotlovs commented on a change in pull request #32080:
URL: https://github.com/apache/spark/pull/32080#discussion_r609089318



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1031,6 +1031,8 @@ object SparkSubmit extends CommandLineUtils with Logging {
         } catch {
           case e: SparkUserAppException =>
             exitFn(e.exitCode)
+          case _: Throwable => 
+            exitFn(1)

Review comment:
       This changes will not fix [the problem](https://issues.apache.org/jira/browse/SPARK-34674) completely.
   If the main() method completes successfully,  the application will still hang in K8S.
   Could you consider also call to exitFn in case of successfull?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org