[GitHub] [incubator-brpc] jamesge commented on a change in pull request #717: Revive from all server failed

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #717: Revive from all server failed
URL: https://github.com/apache/incubator-brpc/pull/717#discussion_r275634715
 
 

 ##########
 File path: src/butil/string_splitter.h
 ##########
 @@ -159,6 +160,82 @@ class StringMultiSplitter {
     const EmptyFieldAction _empty_field_action;
 };
 
+// Split query in the format according to the given delimiters.
+// This class can also handle some exceptional cases, such as
+// consecutive ampersand, only equal sign, only key and so on.
+class KeyValuePairsSplitter {
 
 Review comment:
   这部分的修改以及brpc用到splitter一些代码的调整单独拆一个PR吧。上面的StringSplitter也可以支持下StringPiece接口，包括构造函数和返回StringPiece的field函数（可以叫field_sp)
   另外需要说明支持的一般化格式，比如分隔符是否可以重复（目前可以），=是否可以重复（目前不可以）。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org