You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/26 11:43:32 UTC

[GitHub] flink pull request #3998: [FLINK-6661][web] Merge "Subtasks" and "Taskmanage...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3998

    [FLINK-6661][web] Merge "Subtasks" and "Taskmanagers" view

    This PR merges the `Subtasks` and `SubtasksByTaskManager` view. A checkbox was added to switch between modes.
    
    As usual, some impressive pictures to gaze upon:
    ![subtasks](https://cloud.githubusercontent.com/assets/5725237/26493344/3cf545d0-4219-11e7-88ed-3b62d983ae9f.png)
    ![taskmanagers](https://cloud.githubusercontent.com/assets/5725237/26493345/3e3384f2-4219-11e7-8e56-51d042695835.png)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6661_web_st

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3998
    
----
commit f79157294b5822a067091cf5ca96ee242a99fbbe
Author: zentol <ch...@apache.org>
Date:   2017-05-26T11:41:03Z

    [FLINK-6661][web] Merge "Subtasks" and "Taskmanagers" view

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3998: [FLINK-6661][web] Merge "Subtasks" and "SubtasksByTaskMan...

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3998
  
    LGTM. My only suggestion would be to ask if the checkbox description should be lengthened to ""Aggregate statistics by TaskManager" or even "Aggregate task statistics by TaskManager".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3998: [FLINK-6661][web] Merge "Subtasks" and "SubtasksByTaskMan...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3998
  
    we got enough space, so why not be explicit about it :)
    
    Will change it while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3998: [FLINK-6661][web] Merge "Subtasks" and "SubtasksBy...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3998


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---