You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2017/12/13 06:29:34 UTC
[GitHub] nifi-minifi pull request #103: MINIFI-417 Upgrading underlying NiFi libs to ...
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/103
MINIFI-417 Upgrading underlying NiFi libs to 1.4.0 from 1.2.0
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-417-nifi_1.2.0-deps
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit baac89b1ddd7a019635bd150c0cce9a37314a371
Author: Joe Percivall <jp...@apache.org>
Date: 2017-12-13T06:23:22Z
MINIFI-417 Upgrading underlying NiFi libs to 1.4.0 from 1.2.0
----
---
[GitHub] nifi-minifi pull request #103: MINIFI-417 Upgrading underlying NiFi libs to ...
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/103#discussion_r156654291
--- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java ---
@@ -77,7 +77,7 @@
public final class ConfigTransformer {
// Underlying version of NIFI will be using
- public static final String NIFI_VERSION = "1.2.0";
+ public static final String NIFI_VERSION = "1.4.0";
--- End diff --
Any way this value could reference the `org.apache.nifi.version` value in the pom?
---
[GitHub] nifi-minifi pull request #103: MINIFI-417 Upgrading underlying NiFi libs to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/103
---
[GitHub] nifi-minifi pull request #103: MINIFI-417 Upgrading underlying NiFi libs to ...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/103#discussion_r156687353
--- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java ---
@@ -77,7 +77,7 @@
public final class ConfigTransformer {
// Underlying version of NIFI will be using
- public static final String NIFI_VERSION = "1.2.0";
+ public static final String NIFI_VERSION = "1.4.0";
--- End diff --
There appear to be a couple of different ways[1] but most of them are pretty hacky and not sure it's worth putting in for this one variable. If the variable was logic that was relied on for MiNiFi to work I'd probably lean towards adding it but it's currently only used in one place[2] and that is just for documentation within a file that in general isn't viewed by users (the underlying nifi.properties).
[1] https://stackoverflow.com/questions/11500533/access-maven-properties-defined-in-the-pom
[2] https://github.com/JPercivall/nifi-minifi/blob/baac89b1ddd7a019635bd150c0cce9a37314a371/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java#L163
---