You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ya...@apache.org on 2023/10/06 05:20:54 UTC

[spark] branch master updated: [MINOR][SQL] Remove Scalac 2.12-specific code in `InMemoryFileIndex`

This is an automated email from the ASF dual-hosted git repository.

yangjie01 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 78863ad5870a [MINOR][SQL] Remove Scalac 2.12-specific code in `InMemoryFileIndex`
78863ad5870a is described below

commit 78863ad5870a8c40d251ed515181ab2d452afa3c
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Fri Oct 6 13:20:41 2023 +0800

    [MINOR][SQL] Remove Scalac 2.12-specific code in `InMemoryFileIndex`
    
    ### What changes were proposed in this pull request?
    
    This PR aims to remove `scalac 2.12`-specific code from InMemoryFileIndex class.
    
    ### Why are the changes needed?
    
    Like the comment mentioned, we don't need this because `master` branch is using Scala 2.13 only.
    https://github.com/apache/spark/blob/c0d9ca3be14cb0ec8d8f9920d3ecc4aac3cf5adc/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala#L129
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Pass the CIs.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #43233 from dongjoon-hyun/minor_scalac_2.12.
    
    Authored-by: Dongjoon Hyun <dh...@apple.com>
    Signed-off-by: yangjie01 <ya...@baidu.com>
---
 .../org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
index 44d31131e9c6..4d917994123f 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
@@ -126,7 +126,6 @@ class InMemoryFileIndex(
         case None =>
           pathsToFetch += path
       }
-      () // for some reasons scalac 2.12 needs this; return type doesn't matter
     }
     val filter = FileInputFormat.getInputPathFilter(new JobConf(hadoopConf, this.getClass))
     val discovered = InMemoryFileIndex.bulkListLeafFiles(


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org