You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/21 17:32:04 UTC
[GitHub] [kafka] lbradstreet opened a new pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster
lbradstreet opened a new pull request #11619:
URL: https://github.com/apache/kafka/pull/11619
EmbeddedKafkaCluster in other projects use 2MB for their offset map to
reduce memory consumption in test runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lbradstreet commented on a change in pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
lbradstreet commented on a change in pull request #11619:
URL: https://github.com/apache/kafka/pull/11619#discussion_r776132997
##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##########
@@ -135,6 +135,8 @@ private void doStart() {
putIfAbsent(brokerConfig, KafkaConfig.GroupInitialRebalanceDelayMsProp(), 0);
putIfAbsent(brokerConfig, KafkaConfig.OffsetsTopicReplicationFactorProp(), (short) brokers.length);
putIfAbsent(brokerConfig, KafkaConfig.AutoCreateTopicsEnableProp(), false);
+ // reduce the size of the log cleaner map to reduce test memory usage
+ putIfAbsent(brokerConfig, KafkaConfig.LogCleanerDedupeBufferSizeProp(), "2097152");
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lbradstreet commented on a change in pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
lbradstreet commented on a change in pull request #11619:
URL: https://github.com/apache/kafka/pull/11619#discussion_r776117981
##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##########
@@ -135,6 +135,8 @@ private void doStart() {
putIfAbsent(brokerConfig, KafkaConfig.GroupInitialRebalanceDelayMsProp(), 0);
putIfAbsent(brokerConfig, KafkaConfig.OffsetsTopicReplicationFactorProp(), (short) brokers.length);
putIfAbsent(brokerConfig, KafkaConfig.AutoCreateTopicsEnableProp(), false);
+ // reduce the size of the log cleaner map to reduce test memory usage
+ putIfAbsent(brokerConfig, KafkaConfig.LogCleanerDedupeBufferSizeProp(), "2097152");
Review comment:
Cool, I’ll do the same thing as streams then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on a change in pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on a change in pull request #11619:
URL: https://github.com/apache/kafka/pull/11619#discussion_r776089831
##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##########
@@ -135,6 +135,8 @@ private void doStart() {
putIfAbsent(brokerConfig, KafkaConfig.GroupInitialRebalanceDelayMsProp(), 0);
putIfAbsent(brokerConfig, KafkaConfig.OffsetsTopicReplicationFactorProp(), (short) brokers.length);
putIfAbsent(brokerConfig, KafkaConfig.AutoCreateTopicsEnableProp(), false);
+ // reduce the size of the log cleaner map to reduce test memory usage
+ putIfAbsent(brokerConfig, KafkaConfig.LogCleanerDedupeBufferSizeProp(), "2097152");
Review comment:
Makes sense. Just wanted to suggest making it more readable and coincidentally I saw this would make it also same as the one in the equivalent streams class:
https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java#L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11619:
URL: https://github.com/apache/kafka/pull/11619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org