You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/09/12 09:26:15 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #744: SUBMARINE-1012. Submarine CR status is inconsistent with actual state

MortalHappiness opened a new pull request #744:
URL: https://github.com/apache/submarine/pull/744


   ### What is this PR for?
   When creating the submarine using the operator, the status of the submarine CR shows mlflow failed due to time-out processing. However, the mlflow deployment is running.
   
   #### Cause:
   Submarine operator treat progressing error, ex. ProgressDeadlineExceeded, as a fatal error. However, the deployment controller will continue to process failed deployment, so the deployment may be running in several minutes. This causes inconsistent CR status with the actual state.
   
   #### Solution:
   Does not treat progressing error as a fatal error
   
   #### References:
   https://pkg.go.dev/k8s.io/api/apps/v1#DeploymentSpec
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1012
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #744: SUBMARINE-1012. Submarine CR status is inconsistent with actual state

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #744:
URL: https://github.com/apache/submarine/pull/744


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 commented on pull request #744: SUBMARINE-1012. Submarine CR status is inconsistent with actual state

Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #744:
URL: https://github.com/apache/submarine/pull/744#issuecomment-917666352


   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #744: SUBMARINE-1012. Submarine CR status is inconsistent with actual state

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #744:
URL: https://github.com/apache/submarine/pull/744#issuecomment-917599581


   @pingsutw @Kenchu123 Can you help me review this PR? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org