You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/29 03:32:22 UTC
[GitHub] [doris] yinzhijian opened a new pull request, #10483: [fix](nereids) fix some bugs in group
yinzhijian opened a new pull request, #10483:
URL: https://github.com/apache/doris/pull/10483
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yinzhijian commented on a diff in pull request #10483: [fix](nereids) fix some bugs in group
Posted by GitBox <gi...@apache.org>.
yinzhijian commented on code in PR #10483:
URL: https://github.com/apache/doris/pull/10483#discussion_r909368594
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -184,7 +184,7 @@ public void setExplored(boolean explored) {
* @return {@link Optional} of cost and {@link GroupExpression} of physical plan pair.
*/
public Optional<Pair<Double, GroupExpression>> getLowestCostPlan(PhysicalProperties physicalProperties) {
- if (physicalProperties == null || lowestCostPlans.isEmpty()) {
+ if (physicalProperties == null || lowestCostPlans == null || lowestCostPlans.isEmpty()) {
Review Comment:
Well, the latest version has initialized it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10483: [fix](nereids) fix some bugs in group
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #10483:
URL: https://github.com/apache/doris/pull/10483#discussion_r909256844
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -184,7 +184,7 @@ public void setExplored(boolean explored) {
* @return {@link Optional} of cost and {@link GroupExpression} of physical plan pair.
*/
public Optional<Pair<Double, GroupExpression>> getLowestCostPlan(PhysicalProperties physicalProperties) {
- if (physicalProperties == null || lowestCostPlans.isEmpty()) {
+ if (physicalProperties == null || lowestCostPlans == null || lowestCostPlans.isEmpty()) {
Review Comment:
The lowestCostPlans hash been initialed in Line.49. So the lowest cost plans could not be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 merged pull request #10483: [fix](nereids) extractPlan should use physical expressions but is logical expressions actually
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10483:
URL: https://github.com/apache/doris/pull/10483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10483: [fix](nereids) fix some bugs in group
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10483:
URL: https://github.com/apache/doris/pull/10483#issuecomment-1169520661
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org