You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/25 23:00:57 UTC

[GitHub] gianm commented on issue #7124: rework segment metadata query "size" analysis

gianm commented on issue #7124: rework segment metadata query "size" analysis
URL: https://github.com/apache/incubator-druid/issues/7124#issuecomment-467219575
 
 
   I do think it makes sense to have segmentMetadata return the size in bytes instead of the fake-o weird size it reports today. Maybe it makes sense, though, to change the name? i.e. deprecate and retire `"size"` and introduce a new thing that does make sense. That's just to avoid any potential confusion with people querying `"size"` on older versions, thinking they're getting the newer behavior, and getting wrong numbers back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org