You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@cn.ibm.com> on 2016/04/24 02:25:51 UTC
Re: Review Request 46609: [WIP] Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
-----------------------------------------------------------
(Updated April 24, 2016, 8:25 a.m.)
Review request for mesos.
Summary (updated)
-----------------
[WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Repository: mesos
Description (updated)
-------
Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Diffs
-----
src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
Diff: https://reviews.apache.org/r/46609/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 46609: [WIP] Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/#review130707
-----------------------------------------------------------
Bad patch!
Reviews applied: [46609, 46204, 46188, 46187]
Failed command: ./support/apply-review.sh -n -r 46609
Error:
2016-04-27 02:08:39 URL:https://reviews.apache.org/r/46609/diff/raw/ [5233/5233] -> "46609.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.
Full log: https://builds.apache.org/job/mesos-reviewbot/12747/console
- Mesos ReviewBot
On April 27, 2016, 1:26 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46609/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:26 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
>
> Diff: https://reviews.apache.org/r/46609/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 46609: [WIP] Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
-----------------------------------------------------------
(Updated April 27, 2016, 9:26 a.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Summary (updated)
-----------------
[WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558
Repository: mesos
Description
-------
Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Diffs
-----
src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
Diff: https://reviews.apache.org/r/46609/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 46609: Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
-----------------------------------------------------------
(Updated April 27, 2016, 9:25 a.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Rebased
Summary (updated)
-----------------
Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558
Repository: mesos
Description
-------
Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
Diff: https://reviews.apache.org/r/46609/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 46609: [WIP] Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/#review130298
-----------------------------------------------------------
Bad patch!
Reviews applied: [46609, 46204, 46188]
Failed command: ./support/apply-review.sh -n -r 46188
Error:
2016-04-24 08:02:18 URL:https://reviews.apache.org/r/46188/diff/raw/ [455/455] -> "46188.patch" [1]
error: patch failed: src/launcher/http_command_executor.cpp:203
error: src/launcher/http_command_executor.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12697/console
- Mesos ReviewBot
On April 24, 2016, 12:26 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46609/
> -----------------------------------------------------------
>
> (Updated April 24, 2016, 12:26 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
>
> Diff: https://reviews.apache.org/r/46609/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 46609: [WIP] Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/#review130679
-----------------------------------------------------------
Can you rebase this?
- Vinod Kone
On April 24, 2016, 12:26 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46609/
> -----------------------------------------------------------
>
> (Updated April 24, 2016, 12:26 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
>
> Diff: https://reviews.apache.org/r/46609/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 46609: [WIP] Add the test
"SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
-----------------------------------------------------------
(Updated April 24, 2016, 8:26 a.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558
Repository: mesos
Description
-------
Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".
Diffs
-----
src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c
Diff: https://reviews.apache.org/r/46609/diff/
Testing
-------
Thanks,
Qian Zhang