You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by bpanneton <gi...@git.apache.org> on 2015/10/02 19:34:01 UTC
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
GitHub user bpanneton opened a pull request:
https://github.com/apache/phoenix/pull/119
Fix for performance.py not using JAVA_HOME
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bpanneton/phoenix missing-java-home-performance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 2043df299ea8bc0d19c33381412ee1aff7a43f2b
Author: Brian Panneton <br...@mail.mil>
Date: 2015-10-02T17:27:30Z
Fix for performance.py not using JAVA_HOME
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by bpanneton <gi...@git.apache.org>.
Github user bpanneton commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-145112736
Yea, that would be better. I'll fix it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by chu11 <gi...@git.apache.org>.
Github user chu11 commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-145141680
There's another call to 'java' later on in the performance.py that also needs to be adjusted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by bpanneton <gi...@git.apache.org>.
Github user bpanneton commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-145114015
Patch should now follow how queryserver.py gets the JAVA_HOME dir
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by bpanneton <gi...@git.apache.org>.
Github user bpanneton commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-146227005
Updated to have sqlline, sqlline-thing and psql in there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by bpanneton <gi...@git.apache.org>.
Github user bpanneton commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-145143153
Fixed the java that I missed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by chu11 <gi...@git.apache.org>.
Github user chu11 commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-145145800
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Fix for performance.py not using JAVA_HOME
Posted by chu11 <gi...@git.apache.org>.
Github user chu11 commented on the pull request:
https://github.com/apache/phoenix/pull/119#issuecomment-145111243
Note: This patch is for https://issues.apache.org/jira/browse/PHOENIX-2303
My only comment is should this patch look at hbase-env (similar to queryserver.py)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---