You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/18 16:34:46 UTC
[GitHub] [beam] ibzib opened a new pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
ibzib opened a new pull request #11739:
URL: https://github.com/apache/beam/pull/11739
…ctions annotation.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r426758985
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
+ UsesUnboundedPCollections.class,
Review comment:
It might be better to follow-up with the PR author as to why they added `.setIsBoundedInternal(IsBounded.UNBOUNDED)` instead and have different variants of runners execute the test (batch/streaming/...).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11739:
URL: https://github.com/apache/beam/pull/11739#issuecomment-637128985
Run Spark ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11739:
URL: https://github.com/apache/beam/pull/11739#issuecomment-630992600
Run Samza ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11739:
URL: https://github.com/apache/beam/pull/11739#issuecomment-640470028
I am merging this 'eagerly' because it is already two weeks of the VR suite broken and I don't see a stronger reason to not do it, if someone thinks something else is missing please let a comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r433506182
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
+ UsesUnboundedPCollections.class,
Review comment:
I split the test into batch and streaming variants, PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r434869939
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
+ UsesUnboundedPCollections.class,
Review comment:
ping @lukecwik @reuvenlax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia merged pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
iemejia merged pull request #11739:
URL: https://github.com/apache/beam/pull/11739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on a change in pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r432878308
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
+ UsesUnboundedPCollections.class,
Review comment:
I think it was so that it would run on a streaming runner (especially the Dataflow runner). ValidatesRunner tests that use TestStream don't run on Dataflow today I believe, and we have several other places in our test codebase where this pattern is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r426758985
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
+ UsesUnboundedPCollections.class,
Review comment:
It might be better to follow-up with the PR author as to why they added `.setIsBoundedInternal(IsBounded.UNBOUNDED)` instead of leaving it be bounded and have different variants of runners execute the test (batch/streaming/...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11739: [BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11739:
URL: https://github.com/apache/beam/pull/11739#issuecomment-630299564
Run Spark ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org