[GitHub] [beam] lastomato commented on a change in pull request #12661: Add export FHIR resources to GCS IO Connector

[GitBox <gi...@apache.org>]

lastomato commented on a change in pull request #12661:
URL: https://github.com/apache/beam/pull/12661#discussion_r477002138



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##########
@@ -220,6 +222,19 @@ public static Import importResources(
     return new Import(fhirStore, tempDir, deadLetterDir, contentStructure);
   }
 
+  /**
+   * Export resources to GCS. Intended for use on non-empty FHIR stores
+   *
+   * @param fhirStore the fhir store

Review comment:
       I think it's better to add a bit more details here, e.g. the format of an FHIR store name, and the GCS URI prefix etc.

##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##########
@@ -1175,4 +1190,94 @@ public void executeBundles(ProcessContext context) {
       }
     }
   }
+
+  /** Export FHIR resources from a FHIR store to new line delimited json files on GCS. */
+  public static class ExportGcs extends PTransform<PBegin, ExportGcs.Result> {

Review comment:
       We might want to add some tests for this. You can find a few examples added by Jacob previously.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org