[GitHub] [spark] s1ck commented on a change in pull request #24851: [SPARK-27303][GRAPH] Add Spark Graph API

[GitBox <gi...@apache.org>]

s1ck commented on a change in pull request #24851: [SPARK-27303][GRAPH] Add Spark Graph API
URL: https://github.com/apache/spark/pull/24851#discussion_r333374185
 
 

 ##########
 File path: graph/api/src/main/scala/org/apache/spark/graph/api/PropertyGraphWriter.scala
 ##########
 @@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.graph.api
+
+import java.util.Locale
+
+import org.apache.spark.sql.SaveMode
+
+abstract class PropertyGraphWriter(val graph: PropertyGraph) {
+
+  protected var saveMode: SaveMode = SaveMode.ErrorIfExists
+  protected var format: String =
+    graph.cypherSession.sparkSession.sessionState.conf.defaultDataSourceName
+
+  /**
+   * Specifies the behavior when the graph already exists. Options include:
+   * <ul>
+   * <li>`SaveMode.Overwrite`: overwrite the existing data.</li>
+   * <li>`SaveMode.Ignore`: ignore the operation (i.e. no-op).</li>
+   * <li>`SaveMode.ErrorIfExists`: throw an exception at runtime.</li>
+   * </ul>
+   * <p>
+   * When writing the default option is `ErrorIfExists`.
+   *
+   * @since 3.0.0
+   */
+  def mode(mode: SaveMode): PropertyGraphWriter = {
+    mode match {
+      case SaveMode.Append =>
+        throw new IllegalArgumentException(s"Unsupported save mode: $mode. " +
+          "Accepted save modes are 'overwrite', 'ignore', 'error', 'errorifexists'.")
+      case _ =>
+        this.saveMode = mode
+    }
+    this
+  }
+
+  /**
+   * Specifies the behavior when the graph already exists. Options include:
+   * <ul>
+   * <li>`overwrite`: overwrite the existing graph.</li>
+   * <li>`ignore`: ignore the operation (i.e. no-op).</li>
+   * <li>`error` or `errorifexists`: default option, throw an exception at runtime.</li>
+   * </ul>
+   *
+   * @since 3.0.0
+   */
+  def mode(saveMode: String): PropertyGraphWriter = {
+    saveMode.toLowerCase(Locale.ROOT) match {
+      case "overwrite" => mode(SaveMode.Overwrite)
+      case "ignore" => mode(SaveMode.Ignore)
+      case "error" | "errorifexists" => mode(SaveMode.ErrorIfExists)
+      case "default" => this
 
 Review comment:
   Makes sense. It was a copy paste error from the `DataFrameWriter`: https://github.com/apache/spark/blob/c8159c7941f51caf3d420c8ad8599b869fc56a08/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L91
   
   Maybe somebody should fix that too ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org