[GitHub] [hadoop] adoroszlai commented on issue #1256: HDDS-1937. Acceptance tests fail if scm webui shows invalid json

[GitBox <gi...@apache.org>]

adoroszlai commented on issue #1256: HDDS-1937. Acceptance tests fail if scm webui shows invalid json
URL: https://github.com/apache/hadoop/pull/1256#issuecomment-523414219
 
 
   > 1. It's hard to follow the sections where set -e/+e are enabled. With the new approach they set in the scope of the selected methods. I think it's easier to understand that which methods can fail
   
   True, but I have two concerns about the new approach, not sure how real in practice they are:
   
   1. The functions assume the flag was off previously (in case of success, they turn off the flag, regardless of its prior value)
   2. Flag is not reset if the function returns due to error
   
   > 2. It's hard to debug the script locally with source testlib.sh and execute the command because most of the time the shell can be exited and hard to follow why...
   
   Agreed.  Maybe it should be set in the caller scripts (`test.sh`) instead of the library.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org