[jira] [Commented] (FLINK-5520) Disable outer joins with non-equality predicates

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826379#comment-15826379 ] 

ASF GitHub Bot commented on FLINK-5520:
---------------------------------------

GitHub user lincoln-lil opened a pull request:

    https://github.com/apache/flink/pull/3141

    [FLINK-5520] [table] Disable outer joins with non-equality predicates

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lincoln-lil/flink FLINK-5520

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3141
    
----
commit be877a3a9bb9d00f54fbb929e805f95af1ed1cd2
Author: lincoln-lil <li...@gmail.com>
Date:   2017-01-17T14:42:39Z

    [FLINK-5520] [table] Disable outer joins with non-equality predicates

----


> Disable outer joins with non-equality predicates
> ------------------------------------------------
>
>                 Key: FLINK-5520
>                 URL: https://issues.apache.org/jira/browse/FLINK-5520
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: lincoln.lee
>            Priority: Blocker
>             Fix For: 1.2.0
>
>
> Outer joins with non-equality predicates (and at least one equality predicate) compute incorrect results. 
> Since this is not a very common requirement, I propose to disable this feature for the 1.2.0 release and correctly implement it for a later version.
> The fix should add checks in the Table API validation phase (to get a good error message) and in the DataSetJoinRule to prevent translation of SQL queries with non-equality predicates on outer joins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)