You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/15 21:21:31 UTC

[GitHub] [pulsar] bdunn313 opened a new pull request #10245: [docs] Fix mismatch in retention size examples.

bdunn313 opened a new pull request #10245:
URL: https://github.com/apache/pulsar/pull/10245


   Currently, there's a mismatch in the examples provided for setting namespace retention size and getting said retention size. Since the docs show these examples together, it seems like they were intended to be consistent between examples.
   
   This proposed change assumes that the "Get retention" `pulsar-admin` example is correct, and modifies the "Set retention" `pulsar-admin` example to match.
   
   ### Motivation
   
   Reduce confusion from what appears to be a typo in documentation.
   
   ### Modifications
   
   One-line change to an example.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations:no
     - The wire protocol: no
     - The rest endpoints:no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable 
     - If a feature is not applicable for documentation, explain why? not applicable 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10245: [docs] Fix mismatch in retention size examples.

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10245:
URL: https://github.com/apache/pulsar/pull/10245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org