You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org> on 2015/12/09 21:32:56 UTC

Change in hyracks[master]: Disable non-JDK 8 build profiles.

Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/545

Change subject: Disable non-JDK 8 build profiles.
......................................................................

Disable non-JDK 8 build profiles.

We use Java 8 specific features now, so we shouldn't bother
with any profiles for compiler settings older than that.

Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
---
M pom.xml
1 file changed, 1 insertion(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/hyracks refs/changes/45/545/1

diff --git a/pom.xml b/pom.xml
index 368ba2a..fbe936d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -44,6 +44,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <jdk.version>1.8</jdk.version>
         <jvm.extraargs/>
         <!-- Definition of tests in various categories which may be excluded -->
         <hanging.pregelix.tests>**/pregelix/**/FailureRecovery*.java</hanging.pregelix.tests>
@@ -279,24 +280,6 @@
           </plugin>
         </plugins>
       </build>
-    </profile>
-    <profile>
-        <id>java6</id>
-        <activation>
-            <jdk>1.6</jdk>
-        </activation>
-         <properties>
-            <jdk.version>1.6</jdk.version>
-         </properties>
-    </profile>
-    <profile>
-        <id>java7</id>
-        <activation>
-            <jdk>1.7</jdk>
-        </activation>
-         <properties>
-            <jdk.version>1.7</jdk.version>
-         </properties>
     </profile>
     <profile>
         <id>java8</id>

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/545
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>

Change in hyracks[master]: Disable non-JDK 8 build profiles.

Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.

Change subject: Disable non-JDK 8 build profiles.
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/545
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in hyracks[master]: Disable non-JDK 8 build profiles.

Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has submitted this change and it was merged.

Change subject: Disable non-JDK 8 build profiles.
......................................................................


Disable non-JDK 8 build profiles.

We use Java 8 specific features now, so we shouldn't bother
with any profiles for compiler settings older than that.

Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Reviewed-on: https://asterix-gerrit.ics.uci.edu/545
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <ti...@apache.org>
Reviewed-by: Chris Hillery <ce...@lambda.nu>
---
M pom.xml
1 file changed, 1 insertion(+), 18 deletions(-)

Approvals:
  Chris Hillery: Looks good to me, approved
  Till Westmann: Looks good to me, approved
  Jenkins: Verified



diff --git a/pom.xml b/pom.xml
index 368ba2a..fbe936d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -44,6 +44,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <jdk.version>1.8</jdk.version>
         <jvm.extraargs/>
         <!-- Definition of tests in various categories which may be excluded -->
         <hanging.pregelix.tests>**/pregelix/**/FailureRecovery*.java</hanging.pregelix.tests>
@@ -279,24 +280,6 @@
           </plugin>
         </plugins>
       </build>
-    </profile>
-    <profile>
-        <id>java6</id>
-        <activation>
-            <jdk>1.6</jdk>
-        </activation>
-         <properties>
-            <jdk.version>1.6</jdk.version>
-         </properties>
-    </profile>
-    <profile>
-        <id>java7</id>
-        <activation>
-            <jdk>1.7</jdk>
-        </activation>
-         <properties>
-            <jdk.version>1.7</jdk.version>
-         </properties>
     </profile>
     <profile>
         <id>java8</id>

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/545
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in hyracks[master]: Disable non-JDK 8 build profiles.

Posted by "Chris Hillery (Code Review)" <do...@asterixdb.incubator.apache.org>.
Chris Hillery has posted comments on this change.

Change subject: Disable non-JDK 8 build profiles.
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/545
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in hyracks[master]: Disable non-JDK 8 build profiles.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Disable non-JDK 8 build profiles.
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/656/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/545
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in hyracks[master]: Disable non-JDK 8 build profiles.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Disable non-JDK 8 build profiles.
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/656/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/545
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97b03f76bd7afa66e9be5a20ff64477383525868
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No