You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "solrbot (via GitHub)" <gi...@apache.org> on 2026/09/01 00:47:10 UTC
[PR] Update Error Prone to v2.50.0 [solr]
solrbot opened a new pull request, #4847:
URL: https://github.com/apache/solr/pull/4847
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://redirect.github.com/google/error-prone)) | dependencies | minor | `2.41.0` → `2.50.0` |
| [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://redirect.github.com/google/error-prone)) | dependencies | minor | `2.41.0` → `2.50.0` |
---
### Release Notes
<details>
<summary>google/error-prone (com.google.errorprone:error_prone_core)</summary>
### [`v2.50.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.50.0): Error Prone 2.50.0
New checks:
- [`BoxingComparator`](https://errorprone.info/bugpattern/BoxingComparator): Detect implicitly-boxing Comparator.comparing key extractors
- [`ExposedPrivateType`](https://errorprone.info/bugpattern/ExposedPrivateType): Discourage references to private member classes from non-private APIs
- [`JUnitMethodInvoked`](https://errorprone.info/bugpattern/JUnitMethodInvoked): Discourage directly invoking JUnit test methods
- [`ListRemoveAmbiguous`](https://errorprone.info/bugpattern/ListRemoveAmbiguous): Detect ambiguous calls to `List.remove(int|Integer)`
- [`PreferTestParameter`](https://errorprone.info/bugpattern/PreferTestParameter): suggests using `@TestParameter` instead of `@TestParameters` for exhaustive boolean and enum parameters on single-element parameterized tests
- [`RecordComponentAccessorAnnotationConflict`](https://errorprone.info/bugpattern/RecordComponentAccessorAnnotationConflict): Detect conflicts between record components and explicit accessor methods
- [`RecordComponentOverride`](https://errorprone.info/bugpattern/RecordComponentOverride): Discourage `@Override` on record component declarations that don't override
anything
- [`ThrowableEqualsHashCode`](https://errorprone.info/bugpattern/ThrowableEqualsHashCode): Discourage overriding `Throwable.equals()` and `hashCode()`
Closed issues: [#​5553](https://redirect.github.com/google/error-prone/issues/5553), [#​5649](https://redirect.github.com/google/error-prone/issues/5649), [#​5778](https://redirect.github.com/google/error-prone/issues/5778)
Full changelog: <https://github.com/google/error-prone/compare/v2.49.0...v2.50.0>
### [`v2.49.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.49.0): Error Prone 2.49.0
This release includes several changes to `Matcher` APIs, and removed some deprecated or problematic APIs:
- Remove deprecated `MethodMatchers.withSignature` API, which relies on fragile `toString` behaviour. Alternatives for matching on method signatures with varargs and type parameters were added in [`a98a1c5`](https://redirect.github.com/google/error-prone/commit/a98a1c55d92d343ae2c142485e8888cd46aa78b3).
- Removed `variableType(Matcher)` API. `Matchers.variableType(Matcher)` uses `VariableTree#getType` to match variable types, which own't work for lambda parameters with inferred types after [JDK-8268850](https://bugs.openjdk.org/browse/JDK-8268850). The recommended replacement is `variableType(TypePredicate)`.
- Make `enclosingPackage` return an optional. Module elements are not enclosed by a package, checks using `enclosingPackage` shouldn't assume an enclosing package exists when processing arbitrary elements.
- New `FieldMatchers` API, similar to `MethodMatchers` ([`1dd9c3a`](https://redirect.github.com/google/error-prone/commit/1dd9c3a6bd76fca8104be6ae1c1004655d6a1745)).
New checks:
- [`AssertThrowsBlockToExpression`](https://errorprone.info/bugpattern/AssertThrowsBlockToExpression): Discourage unnecessary block lambdas in `assertThrows`.
- [`AssertThrowsMinimizer`](https://errorprone.info/bugpattern/AssertThrowsMinimizer): Suggest minimizing the amount of logic in `assertThrows`.
- [`MemorySegmentReferenceEquality`](https://errorprone.info/bugpattern/MemorySegmentReferenceEquality): Discourage using reference equality for `MemorySegments`.
- [`PreferThrowsTag`](https://errorprone.info/bugpattern/PreferThrowsTag): Recommends using `@throws` instead of the legacy `@exception` javadoc tag.
- [`RecordAccessorInCompactConstructor`](https://errorprone.info/bugpattern/RecordAccessorInCompactConstructor): detect record accessors inside the compact canonical ctors, which read uninitialized fields.
Closed issues: [#​2283](https://redirect.github.com/google/error-prone/issues/2283), [#​3503](https://redirect.github.com/google/error-prone/issues/3503), [#​5210](https://redirect.github.com/google/error-prone/issues/5210), [#​5289](https://redirect.github.com/google/error-prone/issues/5289), [#​5548](https://redirect.github.com/google/error-prone/issues/5548), [#​5548](https://redirect.github.com/google/error-prone/issues/5548), [#​5554](https://redirect.github.com/google/error-prone/issues/5554), [#​5609](https://redirect.github.com/google/error-prone/issues/5609), [#​5614](https://redirect.github.com/google/error-prone/issues/5614), [#​5656](https://redirect.github.com/google/error-prone/issues/5656)
Full changelog: <https://github.com/google/error-prone/compare/v2.48.0...v2.49.0>
### [`v2.48.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.48.0): Error Prone 2.48.0
Changes:
- Added support for passing flags with command-line argument files (`@`-files) ([`8e84edf`](https://redirect.github.com/google/error-prone/commit/8e84edf1beedc99ff2cff3c21a7adec578ad053e))
New checks:
- [`AvoidValueSetter`](https://errorprone.info/bugpattern/AvoidValueSetter)
- [`UnnecessarySemicolon`](https://errorprone.info/bugpattern/UnnecessarySemicolon)
Closed issues: [#​5529](https://redirect.github.com/google/error-prone/issues/5529), [#​5537](https://redirect.github.com/google/error-prone/issues/5537), [#​5522](https://redirect.github.com/google/error-prone/issues/5522), [#​5521](https://redirect.github.com/google/error-prone/issues/5521)
Full changelog: <https://github.com/google/error-prone/compare/v2.47.0...v2.48.0>
### [`v2.47.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.47.0): Error Prone 2.47.0
New checks:
- [`InterruptedInCatchBlock`](https://errorprone.info/bugpattern/InterruptedInCatchBlock): Detect accidental calls to `Thread.interrupted()` inside of `catch(InterruptedException e)` blocks.
- [`RefactorSwitch`](https://errorprone.info/bugpattern/RefactorSwitch): Refactorings to simplify arrow switches
- [`UnnamedVariable`](https://errorprone.info/bugpattern/UnnamedVariable): Rename unused variables to `_`
Closed issues: [#​1811](https://redirect.github.com/google/error-prone/issues/1811), [#​4168](https://redirect.github.com/google/error-prone/issues/4168), [#​5459](https://redirect.github.com/google/error-prone/issues/5459), [#​5460](https://redirect.github.com/google/error-prone/issues/5460)
Full changelog: <https://github.com/google/error-prone/compare/v2.46.0...v2.47.0>
### [`v2.46.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.46.0): Error Prone 2.46.0
Changes:
- The javac flag `-XDaddTypeAnnotationsToSymbol=true` is now required for Error Prone invocations on JDK 21, to enable the javac fix for [JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries](https://bugs.openjdk.org/browse/JDK-8225377). See [#​5426](https://redirect.github.com/google/error-prone/issues/5426) for details.
- Remove deprecated `value` attribute from `@IncompatibleModifiers` and `@RequiredModifiers` ([#​2122](https://redirect.github.com/google/error-prone/issues/2122))
- Error Prone API changes to encapsulate references to internal javac APIs for end position handling (`EndPosTable`, `DiagnosticPosition`) ([`5440bb4`](https://redirect.github.com/google/error-prone/commit/5440bb4bcd9d3455a131d863b09f71cfea8a346b), [`06c2905`](https://redirect.github.com/google/error-prone/commit/06c2905e03ade5e1564b5c67d44e2e34bfe5b8e4), [`f3915ec`](https://redirect.github.com/google/error-prone/commit/f3915ec322fa7f190c670f6a30bd476f463d8967))
New checks:
- [`DuplicateAssertion`](https://errorprone.info/bugpattern/DuplicateAssertion): detect duplicated assertion lines where the argument to `assertThat` is pure
- [`IfChainToSwitch`](https://errorprone.info/bugpattern/IfChainToSwitch): suggest converting chains of if-statements into arrow switches
- [`ScannerUseDelimiter`](https://errorprone.info/bugpattern/ScannerUseDelimiter): discourage `Scanner.useDelimiter("\\A")`
- [`AddNullMarkedToClass`](https://errorprone.info/bugpattern/AddNullMarkedToClass): refactoring to add `@NullMarked` annotation to top level classes
Full changelog: <https://github.com/google/error-prone/compare/v2.45.0...v2.46.0>
### [`v2.45.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.45.0): Error Prone 2.45.0
Changes:
- Improved compatibility with latest JDK 26 EA builds.
New checks:
- [`AssertSameIncompatible`](https://errorprone.info/bugpattern/AssertSameIncompatible): Detect calls to `assertSame` and similar assertions, where the calls are guaranteed to either succeed or fail.
- [`FormatStringShouldUsePlaceholders`](https://errorprone.info/bugpattern/FormatStringShouldUsePlaceholders): Suggests using a format string instead of string concatenation operations on format methods
Closed issues: [#​5335](https://redirect.github.com/google/error-prone/issues/5335)
Full changelog: <https://github.com/google/error-prone/compare/v2.44.0...v2.45.0>
### [`v2.44.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.44.0): Error Prone 2.44.0
Changes
- The default severity for [`LabelledBreakTarget`](https://errorprone.info/bugpattern/LabelledBreakTarget) is now an error
- Update dependency on Guava ([#​5108](https://redirect.github.com/google/error-prone/issues/5108))
Closed issues: [#​5218](https://redirect.github.com/google/error-prone/issues/5218), [#​5278](https://redirect.github.com/google/error-prone/issues/5278)
Full changelog: <https://github.com/google/error-prone/compare/v2.43.0...v2.44.0>
### [`v2.43.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.43.0): Error Prone 2.43.0
The minimum supported JDK version to run Error Prone is now JDK 21 ([#​4867](https://redirect.github.com/google/error-prone/issues/4867)).
Changes:
- `-XepPatchChecks` now skips disabled checks ([#​4943](https://redirect.github.com/google/error-prone/issues/4943))
- `AndroidJdkLibsChecker` has been removed, the recommended replacement for Android code is Android Lint's NewApi check
New checks:
- [`NullNeedsCastForVarargs`](https://errorprone.info/bugpattern/NullNeedsCastForVarargs): Detect calls that incorrectly passes a `null` *array* instead of a `null` *element*.
- [`RedundantNullCheck`](https://errorprone.info/bugpattern/RedundantNullCheck): detect checks on expressions that are non-null.
Closed issues: [#​4943](https://redirect.github.com/google/error-prone/issues/4943), [#​5102](https://redirect.github.com/google/error-prone/issues/5102), [#​5107](https://redirect.github.com/google/error-prone/issues/5107), [#​5121](https://redirect.github.com/google/error-prone/issues/5121), [#​5158](https://redirect.github.com/google/error-prone/issues/5158), [#​5217](https://redirect.github.com/google/error-prone/issues/5217), [#​5239](https://redirect.github.com/google/error-prone/issues/5239)
Full changelog: <https://github.com/google/error-prone/compare/v2.42.0...v2.43.0>
### [`v2.42.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.42.0): Error Prone 2.42.0
New checks:
- [`ExplicitArrayForVarargs`](https://errorprone.info/bugpattern/ExplicitArrayForVarargs): discourage unnecessary explicit construction of an array to provide varargs.
- [`FloggerPerWithoutRateLimit`](https://errorprone.info/bugpattern/FloggerPerWithoutRateLimit): discourage Flogger's `perUnique` without rate limiting
- [`StringJoin`](https://errorprone.info/bugpattern/StringJoin): Ban `String.join(CharSequence)` and `String.join(CharSequence, CharSequence)`
- [`ThreadBuilderNameWithPlaceholder`](https://errorprone.info/bugpattern/ThreadBuilderNameWithPlaceholder): Do not allow placeholders in `Thread.Builder.name(String)` or `name(String, int)`.
Changes:
- The return type of `ASTHelpers.asFlagSet` has changed. The previous type was `EnumSet<Flags.Flag>`, where `Flags.Flag` is an enum in the javac class `Flags`. A recent JDK change has replaced that enum with a new top-level enum called `FlagsEnum`. It is not possible to change `ASTHelpers.asFlagSet` in a way that would be type-safe and compatible with the enums from JDKs both before and after the change. Instead, the method now returns `ImmutableSet<String>`, where the strings come from the `toString()` of the enum constants. That means they are `"native"`, `"abstract"`, etc.
- Flag `IO.print[ln]()` in [`SystemOut`](https://errorprone.info/bugpattern/SystemOut).
Full changelog: <https://github.com/google/error-prone/compare/v2.41.0...v2.42.0>
</details>
---
### Configuration
📅 **Schedule**: (UTC)
- Branch creation
- "before 9am on the first day of the month"
- Automerge
- At any time (no schedule defined)
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action)
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNzAuMTgiLCJ1cGRhdGVkSW5WZXIiOiI0My4xNzAuMTgiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImV4ZW1wdC1zdGFsZSJdfQ==-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3929876080
##########
solr/core/src/java/org/apache/solr/handler/component/StatsField.java:
##########
@@ -84,7 +84,7 @@ public enum Stat {
distinctValues(true),
countDistinct(false, distinctValues),
percentiles(true) {
- /** special for percentiles * */
+ /* special for percentiles */
Review Comment:
I disagree with `NotJavadoc` rule. The creator of the rule apparently thinks the only point of Javadoc is to publish it. I rarely look at **published** javadoc nowadays. I view javadoc as the normal way that a class/field/member is documented. And it even looks fairly nice nowadays in IntelliJ with the rendered view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3929928329
##########
solr/core/src/java/org/apache/solr/handler/component/StatsField.java:
##########
@@ -84,7 +84,7 @@ public enum Stat {
distinctValues(true),
countDistinct(false, distinctValues),
percentiles(true) {
- /** special for percentiles * */
+ /* special for percentiles */
Review Comment:
Further argument: Imagine I have some class with javadoc... and then I do a refactoring that turns it into an anonymous inner class. Why should I then be forced to turn javadocs to non-javadoc? Seems arbitrary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #4847:
URL: https://github.com/apache/solr/pull/4847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4847:
URL: https://github.com/apache/solr/pull/4847#issuecomment-5539584729
So, the feedback wasn't waht I expected! Just to confirm, I am going to back out the `NotJavadoc` but keep the `ReferenceEquality`.. that works for me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3940570094
##########
gradle/validation/error-prone.gradle:
##########
@@ -456,7 +456,7 @@ allprojects {prj ->
'-Xep:NonCanonicalType:WARN',
'-Xep:NonOverridingEquals:WARN',
//'-Xep:NonFinalStaticField:WARN', // todo there are problems that should be fixed
- '-Xep:NotJavadoc:WARN',
+ // '-Xep:NotJavadoc:OFF', // too many false positives on stacked/non-public-API comments
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4847:
URL: https://github.com/apache/solr/pull/4847#issuecomment-5539833400
Okay, this shold be good to go. When I was working on this the first time, I found one dangling javadoc comment that needed removeal, and I couln't stomach a whole new PR for it, so its in commit e56ac5b8ff028ab54e2a8c9f4ed2b896eb24e344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3934972987
##########
gradle/validation/error-prone.gradle:
##########
@@ -456,7 +456,7 @@ allprojects {prj ->
'-Xep:NonCanonicalType:WARN',
'-Xep:NonOverridingEquals:WARN',
//'-Xep:NonFinalStaticField:WARN', // todo there are problems that should be fixed
- '-Xep:NotJavadoc:WARN',
+ // '-Xep:NotJavadoc:OFF', // too many false positives on stacked/non-public-API comments
Review Comment:
the rationale is inconsistent with the rationale I stated. I suggest simply "we disagree; javadocs aren't purely for publishing"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4847:
URL: https://github.com/apache/solr/pull/4847#issuecomment-5531748639
FYI https://errorprone.info/bugpattern/ReferenceEquality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4847:
URL: https://github.com/apache/solr/pull/4847#issuecomment-5529565798
The new ErrorProne brought a set of new rules, some that are great, and one that maybe needs discussion. This commit is all reasonable seeming fixes/cleanups: 0743dd4ecd651638dbcc52a1b8e7aba4e2a754a2, however the suppression of `ReferenceEquality` was a LOT! See https://github.com/apache/solr/pull/4847/changes/3c713f109fde8b367f2ed4150ae66497cb9ebaed and I don't know what we think about this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3933406529
##########
solr/core/src/java/org/apache/solr/handler/component/StatsField.java:
##########
@@ -84,7 +84,7 @@ public enum Stat {
distinctValues(true),
countDistinct(false, distinctValues),
percentiles(true) {
- /** special for percentiles * */
+ /* special for percentiles */
Review Comment:
I am onboard with changing the defaults that we are applying to ErrorProne. In some projects with these types of chekcers we just adopt "we'll follow what they recommend' and just keep updating to keep abrest. Obviously most of the rules in ErrorProne we don't follow and we just pick and choose. I can back out the `NotJavadoc` rule.... I suspected you would have an opinion ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update Error Prone to v2.50.0 [solr]
Posted by "solrbot (via GitHub)" <gi...@apache.org>.
solrbot commented on PR #4847:
URL: https://github.com/apache/solr/pull/4847#issuecomment-5530318424
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ **Warning**: custom changes will be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org