[GitHub] [samza] cameronlee314 commented on a change in pull request #1583: SAMZA-2721: Container should exit with non-zero status code in case of errors during launch

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1583:
URL: https://github.com/apache/samza/pull/1583#discussion_r806159097



##########
File path: samza-core/src/main/java/org/apache/samza/runtime/ContainerLaunchUtil.java
##########
@@ -179,15 +181,26 @@ private static void run(
 
       if (containerRunnerException != null) {
         log.error("Container stopped with Exception. Exiting process now.", containerRunnerException);
-        System.exit(1);
+        exitProcess(1);
       }
     } catch (Throwable e) {
-      log.error("Container stopped with Exception. ", containerRunnerException);
+      log.error("Exiting the process due to {}. \nContainer runner exception: {}", e, containerRunnerException);

Review comment:
       I didn't think the logger actually prints the full stack trace if you do it this way. I think it will just print some message, but it would be helpful to have the full stack trace. If so, could you log them separately instead? Maybe you could also do a null check on `containerRunnerException` for printing it out or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org