You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/10 00:03:24 UTC

[kudu-CR] python: bump version number to 0.3.0

Hello David Ribeiro Alves, Jordan Birdsell,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4364

to review the following change.

Change subject: python: bump version number to 0.3.0
......................................................................

python: bump version number to 0.3.0

There have been some changes to the Python client since our last ASF
release, so we need to bump the version number before we do our next ASF
release.

Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
---
M python/setup.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/4364/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>

[kudu-CR] python: bump version number to 0.3.0

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: python: bump version number to 0.3.0
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] python: bump version number to 0.3.0

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: python: bump version number to 0.3.0
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4364/1/python/setup.py
File python/setup.py:

PS1, Line 31: if Cython.__version__ < '0.19.1':
            :     raise Exception('Please upgrade to Cython 0.19.1 or newer')
Just noticed this, while we're updating the version, should we go ahead and correct this to the currently required version of Cython according the requirements.txt (0.21.1)?


-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] python: bump version number to 0.3.0

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: python: bump version number to 0.3.0
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] python: bump version number to 0.3.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: python: bump version number to 0.3.0
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3329/

-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] python: bump version number to 0.3.0

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: python: bump version number to 0.3.0
......................................................................


python: bump version number to 0.3.0

There have been some changes to the Python client since our last ASF
release, so we need to bump the version number before we do our next ASF
release.

Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Reviewed-on: http://gerrit.cloudera.org:8080/4364
Tested-by: Kudu Jenkins
Reviewed-by: Jordan Birdsell <jo...@gmail.com>
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
---
M python/setup.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Jordan Birdsell: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] python: bump version number to 0.3.0

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: python: bump version number to 0.3.0
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4364/1/python/setup.py
File python/setup.py:

PS1, Line 31: if Cython.__version__ < '0.19.1':
            :     raise Exception('Please upgrade to Cython 0.19.1 or newer')
> Just noticed this, while we're updating the version, should we go ahead and
sure. I did that in a separate commit: http://gerrit.cloudera.org:8080/4368


-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes