You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ha...@apache.org on 2022/11/03 02:26:25 UTC

[iotdb] branch master updated: add: define a constant instead load manager metrics. (#7835)

This is an automated email from the ASF dual-hosted git repository.

haonan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 0c34ee1d9c add: define a constant instead load manager metrics. (#7835)
0c34ee1d9c is described below

commit 0c34ee1d9c626e755d207598ff181c6b0482eb4b
Author: Leon Ding <de...@qq.com>
AuthorDate: Thu Nov 3 10:26:20 2022 +0800

    add: define a constant instead load manager metrics. (#7835)
---
 .../org/apache/iotdb/confignode/conf/ConfigNodeConstant.java   |  3 +++
 .../iotdb/confignode/manager/load/LoadManagerMetrics.java      | 10 ++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConstant.java b/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConstant.java
index 41f6ae8d68..b162ae7982 100644
--- a/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConstant.java
+++ b/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConstant.java
@@ -47,6 +47,9 @@ public class ConfigNodeConstant {
   public static final String METRIC_STATUS_ONLINE = "Online";
   public static final String METRIC_STATUS_UNKNOWN = "Unknown";
 
+  public static final String METRIC_CONFIG_NODE = "ConfigNode";
+  public static final String METRIC_DATA_NODE = "DataNode";
+
   public static final String REMOVE_CONFIGNODE_USAGE =
       "Executed failed, check usage: <Node-id>/<internal_address>:<internal_port>";
 
diff --git a/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManagerMetrics.java b/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManagerMetrics.java
index e594406216..2901dbaa20 100644
--- a/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManagerMetrics.java
+++ b/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManagerMetrics.java
@@ -38,6 +38,8 @@ import java.util.Map;
 import java.util.Objects;
 import java.util.concurrent.ConcurrentHashMap;
 
+import static org.apache.iotdb.confignode.conf.ConfigNodeConstant.METRIC_CONFIG_NODE;
+import static org.apache.iotdb.confignode.conf.ConfigNodeConstant.METRIC_DATA_NODE;
 import static org.apache.iotdb.confignode.conf.ConfigNodeConstant.METRIC_STATUS_ONLINE;
 import static org.apache.iotdb.confignode.conf.ConfigNodeConstant.METRIC_STATUS_UNKNOWN;
 import static org.apache.iotdb.confignode.conf.ConfigNodeConstant.METRIC_TAG_TOTAL;
@@ -207,7 +209,7 @@ public class LoadManagerMetrics implements IMetricSet {
               Tag.NAME.toString(),
               name,
               Tag.TYPE.toString(),
-              "ConfigNode")
+              METRIC_CONFIG_NODE)
           .set(1);
     }
     return runningConfigNodes.size();
@@ -230,7 +232,7 @@ public class LoadManagerMetrics implements IMetricSet {
               Tag.NAME.toString(),
               name,
               Tag.TYPE.toString(),
-              "DataNode")
+              METRIC_DATA_NODE)
           .set(1);
     }
     return runningDataNodes.size();
@@ -252,7 +254,7 @@ public class LoadManagerMetrics implements IMetricSet {
               Tag.NAME.toString(),
               name,
               Tag.TYPE.toString(),
-              "ConfigNode")
+              METRIC_CONFIG_NODE)
           .set(0);
     }
     return unknownConfigNodes.size();
@@ -275,7 +277,7 @@ public class LoadManagerMetrics implements IMetricSet {
               Tag.NAME.toString(),
               name,
               Tag.TYPE.toString(),
-              "DataNode")
+              METRIC_DATA_NODE)
           .set(0);
     }
     return unknownDataNodes.size();