You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "danielcweeks (via GitHub)" <gi...@apache.org> on 2024/03/12 00:50:50 UTC
[PR] Add issue template and docs for iceberg proposals [iceberg]
danielcweeks opened a new pull request, #9932:
URL: https://github.com/apache/iceberg/pull/9932
This PR adds an issue template for Iceberg improvement proposals and adds docs to the site to cover the proposal process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1523260018
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
+description: Propose a Spec change or major feature
+labels: ["proposal"]
+body:
+ - type: markdown
+ attributes:
+ value: "Please see documentation site for information on [contributing proposals](https://iceberg.apache.org/contribute/#iceberg-improvement-proposals)"
Review Comment:
nit: link might need to be updated depending on how the section is going to be named
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1523258200
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,34 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Iceberg Improvement Proposal` template
+2. A document including the following:
+ * Motivation for the change
+ * Implementation proposal
+ * Breaking changes/incompatibilities
+ * Alternatives considered
+3. A discussion thread initiated in the dev list with the Subject: '[DISCUSS] \<proposal title\>'
+
+### Who can submit a proposal?
+
+Anyone can submit a proposal, but be considerate and submit only if you plan on contributing to the implementation.
+
+### Where can I find current proposals?
+
+Current proposals are tracked in GitHub issues with the label [Proposal][iceberg-proposals]
Review Comment:
```suggestion
Current proposals are tracked in GitHub issues with the label [proposal](https://github.com/apache/iceberg/issues?q=is%3Aissue+is%3Aopen+label%3Aproposal+)
```
should this maybe just directly link to the proposals?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1525142424
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,42 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Apache Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Apache Iceberg Improvement Proposal` template
+2. A document including the following:
+ * Motivation for the change
+ * Implementation proposal
+ * Breaking changes/incompatibilities
+ * Alternatives considered
+3. A discussion thread initiated in the dev list with the Subject: '[DISCUSS] <proposal title\>'
+
+### Who can submit a proposal?
+
+Anyone can submit a proposal, but be considerate and submit only if you plan on contributing to the implementation.
+
+### Where can I find current proposals?
+
+Current proposals are tracked in GitHub issues with the label [Proposal][iceberg-proposals]
+
+### How are proposals adopted?
+
+Once general consensus has been reached, a vote should be raised on the dev list. The vote follows the ASF
Review Comment:
For spec/major changes I don't think we want to leave that up to lazy consensus. We should try to achieve consensus before a vote, but the vote is really what codifies the change and removes any ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#issuecomment-1989711615
@jbonofre I'm not sure why I can't add you as a reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1524217993
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
+description: Propose a Spec change or major feature
+labels: ["proposal"]
+body:
+ - type: markdown
+ attributes:
+ value: "Please see documentation site for information on [contributing proposals](https://iceberg.apache.org/contribute/#iceberg-improvement-proposals)"
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1524854248
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,42 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Apache Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
Review Comment:
Maybe also mention "additional features".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1524167782
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,34 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Iceberg Improvement Proposal` template
+2. A document including the following:
+ * Motivation for the change
+ * Implementation proposal
+ * Breaking changes/incompatibilities
+ * Alternatives considered
+3. A discussion thread initiated in the dev list with the Subject: '[DISCUSS] \<proposal title\>'
+
+### Who can submit a proposal?
+
+Anyone can submit a proposal, but be considerate and submit only if you plan on contributing to the implementation.
+
+### Where can I find current proposals?
+
+Current proposals are tracked in GitHub issues with the label [Proposal][iceberg-proposals]
Review Comment:
I prefer the reference since it keeps the text cleaner and is more consistent with other areas of the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1524208288
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
Review Comment:
```suggestion
name: Apache Iceberg Improvement Proposal
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1522025168
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
+description: Propose a Spec change or major feature
+labels: ["proposal"]
+body:
+ - type: markdown
+ attributes:
+ value: "Please see documentation site for information on [contributing proposals](https://iceberg.apache.org/contribute/#iceberg-improvement-proposals)"
+ - type: textarea
+ attributes:
+ label: Proposed Change
+ description: Please describe the proposal and elaborate on the use case and motivation
+ validations:
+ required: true
+ - type: input
+ attributes:
+ label: Proposal document
+ description: |
+ Link to the proposal document. Google Docs is preferred format to allow for public
+ comment and sharing
+ - type: checkboxes
+ attributes:
+ label: Specifications
+ description: Which specifications are affected by this proposal?
+ options:
+ - label: Table
+ - label: View
+ - label: REST
+ - label: Puffin
+ - label: Encryption
Review Comment:
I think this specifically refers to the Encryption spec: https://iceberg.apache.org/gcm-stream-spec/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1524856491
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,42 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Apache Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Apache Iceberg Improvement Proposal` template
+2. A document including the following:
+ * Motivation for the change
+ * Implementation proposal
+ * Breaking changes/incompatibilities
+ * Alternatives considered
+3. A discussion thread initiated in the dev list with the Subject: '[DISCUSS] <proposal title\>'
+
+### Who can submit a proposal?
+
+Anyone can submit a proposal, but be considerate and submit only if you plan on contributing to the implementation.
+
+### Where can I find current proposals?
+
+Current proposals are tracked in GitHub issues with the label [Proposal][iceberg-proposals]
+
+### How are proposals adopted?
+
+Once general consensus has been reached, a vote should be raised on the dev list. The vote follows the ASF
Review Comment:
Do we really need a vote if we already have a lazy consensus ? Either way is fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks merged PR #9932:
URL: https://github.com/apache/iceberg/pull/9932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1520676297
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
+description: Propose a Spec change or major feature
+labels: ["proposal"]
+body:
+ - type: markdown
+ attributes:
+ value: "Please see documentation site for information on [contributing proposals](https://iceberg.apache.org/contribute/#iceberg-improvement-proposals)"
+ - type: textarea
+ attributes:
+ label: Proposed Change
+ description: Please describe the proposal and elaborate on the use case and motivation
+ validations:
+ required: true
+ - type: input
+ attributes:
+ label: Proposal document
+ description: |
+ Link to the proposal document. Google Docs is preferred format to allow for public
+ comment and sharing
+ - type: checkboxes
+ attributes:
+ label: Specifications
+ description: Which specifications are affected by this proposal?
+ options:
+ - label: Table
+ - label: View
+ - label: REST
+ - label: Puffin
+ - label: Encryption
Review Comment:
Should be this `Security`?
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,34 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Iceberg Improvement Proposal` template
Review Comment:
```suggestion
1. A GitHub issue created using the `Apache Iceberg Improvement Proposal` template
```
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,34 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Iceberg Improvement Proposals
Review Comment:
```suggestion
## Apache Iceberg Improvement Proposals
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1525137328
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,42 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Apache Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#issuecomment-1989736901
> @jbonofre I'm not sure why I can't add you as a reviewer.
What I observed is only collaborators, committers can be added as reviewer.
https://github.com/apache/iceberg/blob/main/.asf.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#issuecomment-1990901054
@danielcweeks That's because my user is not in the `collaborators` list in `.asf.yml`. Let me check with asfinfra if we can have more than 10 entries in `collaborators`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1523253714
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
+description: Propose a Spec change or major feature
+labels: ["proposal"]
+body:
+ - type: markdown
+ attributes:
+ value: "Please see documentation site for information on [contributing proposals](https://iceberg.apache.org/contribute/#iceberg-improvement-proposals)"
+ - type: textarea
+ attributes:
+ label: Proposed Change
+ description: Please describe the proposal and elaborate on the use case and motivation
+ validations:
+ required: true
+ - type: input
+ attributes:
+ label: Proposal document
+ description: |
+ Link to the proposal document. Google Docs is preferred format to allow for public
Review Comment:
```suggestion
Link to the proposal document. Google Docs is preferred format to allow for public
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1525150129
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,42 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Apache Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Apache Iceberg Improvement Proposal` template
+2. A document including the following:
+ * Motivation for the change
+ * Implementation proposal
+ * Breaking changes/incompatibilities
+ * Alternatives considered
+3. A discussion thread initiated in the dev list with the Subject: '[DISCUSS] <proposal title\>'
+
+### Who can submit a proposal?
+
+Anyone can submit a proposal, but be considerate and submit only if you plan on contributing to the implementation.
+
+### Where can I find current proposals?
+
+Current proposals are tracked in GitHub issues with the label [Proposal][iceberg-proposals]
+
+### How are proposals adopted?
+
+Once general consensus has been reached, a vote should be raised on the dev list. The vote follows the ASF
Review Comment:
Yeah, I agree for spec/major change. My question was more for proposed new features. But yeah, better to have a vote. I'm just a little bit concerned by potential veto vote. Imagine if we have only +1 and just one -1 from a PMC member, the change/addition can be vetoed. But you are right, we should work on consensus before the vote :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1525150569
##########
site/docs/contribute.md:
##########
@@ -46,6 +46,42 @@ The Iceberg community prefers to receive contributions as [Github pull requests]
* If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft
+## Apache Iceberg Improvement Proposals
+
+### What is an improvement proposal?
+
+An improvement proposal is a major change to Apache Iceberg that may require changes to an existing specification, creation
+of a new specification, or significant changes to any of the existing Iceberg implementations. Changes that are large in
+scope need to be considered carefully and incorporate feedback from many community stakeholders.
+
+### What should a proposal include?
+
+1. A GitHub issue created using the `Apache Iceberg Improvement Proposal` template
+2. A document including the following:
+ * Motivation for the change
+ * Implementation proposal
+ * Breaking changes/incompatibilities
+ * Alternatives considered
+3. A discussion thread initiated in the dev list with the Subject: '[DISCUSS] <proposal title\>'
+
+### Who can submit a proposal?
+
+Anyone can submit a proposal, but be considerate and submit only if you plan on contributing to the implementation.
+
+### Where can I find current proposals?
+
+Current proposals are tracked in GitHub issues with the label [Proposal][iceberg-proposals]
+
+### How are proposals adopted?
+
+Once general consensus has been reached, a vote should be raised on the dev list. The vote follows the ASF
Review Comment:
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add issue template and docs for iceberg proposals [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #9932:
URL: https://github.com/apache/iceberg/pull/9932#discussion_r1524216124
##########
.github/ISSUE_TEMPLATE/iceberg_proposal.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+name: Iceberg Improvement Proposal
Review Comment:
This change would be inconsistent with the other templates (not everything needs the prefix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org