[GitHub] [trafficcontrol] rob05c opened a new pull request #5926: Add t3c-apply flag to wait for parents in syncds mode

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #5926:
URL: https://github.com/apache/trafficcontrol/pull/5926


   Adds a flag to `t3c-apply` to wait for parents in syncds mode. Currently, `--wait-for-parents=true` is the default, but doesn't actually wait in syncds mode, only reval mode.
   
   This changes the flag to a ternary: true, false, and reval. The `reval` option is the new default, and behaves like the old default, so most users should see no change: it waits for parents in reval mode, but not syncds. And `true` now always waits.
   
   The default `reval` is still the recommended option. Config deployments other than revalidations _probably_ don't need to wait for parents in most cases. But config deployment is so complex, it's impossible to say for sure that there are no cases that require waiting for parents. Which is why this flag is being added: so if anyone does encounter an case where it's required (potentially outage-inducing every time there's a change), it's possible to wait for parents in syncds with a flag change, rather than requiring a code change and a new deploy. And it's very little code for that safety, just a new flag and slight modification to the conditional.
   
   Includes extensive tests for all 3 modes (previously wait-for-parents had no tests).
   Includes docs.
   Includes changelog.
   
   - [x] This PR fixes #REPLACE_ME OR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run t3c integration tests. Run t3c-apply with various wait-for-parents arguments, with a cache with parents pending, verify flags do what they say.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   Not a bug fix.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #5926: Add t3c-apply flag to wait for parents in syncds mode

[GitBox <gi...@apache.org>]

zrhoffman merged pull request #5926:
URL: https://github.com/apache/trafficcontrol/pull/5926


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org