You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/26 04:01:04 UTC

[GitHub] codelipenghui commented on a change in pull request #2656: Fix Bug of ConsumerInterceptor on method onAcknowledge()

codelipenghui commented on a change in pull request #2656: Fix Bug of ConsumerInterceptor on method onAcknowledge()
URL: https://github.com/apache/pulsar/pull/2656#discussion_r220420668
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -426,6 +426,8 @@ boolean markAckForBatchMessage(BatchMessageIdImpl batchMessageId, AckType ackTyp
                 && !batchMessageId.getAcker().isPrevBatchCumulativelyAcked()) {
 
 Review comment:
   Why should we add condition of !batchMessageId.getAcker().isPrevBatchCumulativelyAcked()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services