[jira] [Commented] (TAJO-784) Improve TpchTestBase to be more general.

["Tajo QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003769#comment-14003769 ] 

Tajo QA commented on TAJO-784:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12645836/TAJO-784.patch
  against master revision d0528d1.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:green}+1 tests included.{color}  The patch appears to include 42 new or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 195 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in tajo-core.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/430//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/430//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/430//console

This message is automatically generated.

> Improve TpchTestBase to be more general.
> ----------------------------------------
>
>                 Key: TAJO-784
>                 URL: https://issues.apache.org/jira/browse/TAJO-784
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.9.0, 0.8.1
>
>         Attachments: TAJO-784.patch
>
>
> Currently, tajo provides TpchTestBase for TPC-H benchmark. But it is inefficient because it uses all queries which was written in java code. Other test cases use queries which was written in query file. Thus we should refactor it to extend QueryTestCaseBase. In addition, we need to add more TPC-H queries.



--
This message was sent by Atlassian JIRA
(v6.2#6252)