You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/08/04 23:34:54 UTC
Review Request 24264: Installed python libraries during make install.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50315
-----------------------------------------------------------
Bad patch!
Reviews applied: [24264]
Failed command: git apply --index 24264.patch
Error:
error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply
- Mesos ReviewBot
On Aug. 11, 2014, 6:09 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:09 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review52169
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24264]
All tests passed.
- Mesos ReviewBot
On Sept. 2, 2014, 9:25 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 9:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325
> configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089
> mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
> src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
> src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
> src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
> src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review52769
-----------------------------------------------------------
I'm trying to find a policy on checking in binaries to the repo- but my intuition is we shouldn't include wheel and pip in the repo itself- instead we should have a bootstrap script which pulls from PyPI. An example setup script is within Aurora to bootstrap pex[1]
[1] https://github.com/apache/incubator-aurora/blob/master/build-support/pex#L38
- Joe Smith
On Sept. 2, 2014, 2:25 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 2:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325
> configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089
> mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
> src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
> src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
> src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
> src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Sept. 15, 2014, 6:53 p.m., Cody Maloney wrote:
> > src/Makefile.am, line 1043
> > <https://reviews.apache.org/r/24264/diff/11/?file=674261#file674261line1043>
> >
> > Shouldn't we install these globally / not for '--user'?
It isn't getting installed for the user. I'm setting the install location via. `PYTHONUSERBASE`. This is the only way to make sure the python install gets restricted to the same prefix as configured.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review53375
-----------------------------------------------------------
On Sept. 2, 2014, 9:25 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 9:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325
> configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089
> mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
> src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
> src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
> src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
> src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review53375
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/24264/#comment93020>
Shouldn't we install these globally / not for '--user'?
- Cody Maloney
On Sept. 2, 2014, 9:25 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 9:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325
> configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089
> mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
> src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
> src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
> src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
> src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Sept. 2, 2014, 9:25 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325
configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089
mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 27, 2014, 8:45 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325
configure.ac 4b34173ed23bfe4e6f108db57f2611e50927ed2b
mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 26, 2014, 9:32 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac 525d3048ca895952177f35d7c573a1bb3ddd5b3e
mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 11:52 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 11:49 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make
install.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Aug. 14, 2014, 6:28 p.m., Timothy St. Clair wrote:
> > configure.ac, line 903
> > <https://reviews.apache.org/r/24264/diff/6/?file=657733#file657733line903>
> >
> > We have a .m4 that can check python mods
Doesn't look like it checks anything I'd use =/
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50616
-----------------------------------------------------------
On Aug. 25, 2014, 11:52 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:52 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
> mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f
> src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481
> src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274
> src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae
> src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make
install.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50616
-----------------------------------------------------------
Let me know if you want any help on the updated configure checks.
3rdparty/Makefile.am
<https://reviews.apache.org/r/24264/#comment88486>
should wrap with new build mechanics for checking system
configure.ac
<https://reviews.apache.org/r/24264/#comment88485>
We have a .m4 that can check python mods
- Timothy St. Clair
On Aug. 11, 2014, 6:09 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:09 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 6:09 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 6:09 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781
3rdparty/libprocess/include/process/deferred.hpp 8bdc69235c7c25d8c8c0a5a6dcc99c4a2c34f94a
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf
configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
docs/authorization.md 669794457f10e357bdd10b1a096a2ee9b629971f
include/mesos/mesos.proto cc9f20e5cf0ecad58a9c8fa2e4e6e79cea8b344c
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f
src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc
src/credentials/credentials.hpp 4cdadb1b6d5a607cee8caeb38f2cbf2e3ec5da7a
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf
src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4
src/master/flags.hpp 5e9ecb567fb2f4576b38303a9d73b93d8cd14115
src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
src/master/http.cpp 9317a95133e9bba54d037057a147ae6d91125441
src/master/master.hpp c9f989aa209c1067b60d02cfb4f032afe0f9de4c
src/master/master.cpp d53d6c2d2c89258880df42b1c0a2cfb04cffa215
src/sasl/authenticator.hpp 35ab79449093e10877248b91ba7070e04c9cdd6f
src/slave/constants.hpp 9030871fa2c6b449a7eee7644691ca54b0635566
src/slave/constants.cpp e1da5c064b3ea4f2c0d18f4da64111cbea2544d1
src/slave/containerizer/isolators/cgroups/mem.hpp c734dae834c3f771b2954868138a622b7712aa32
src/slave/containerizer/isolators/cgroups/mem.cpp 3ba580d7b5e16ca2ea04c2843780b2e5bc52ec95
src/slave/containerizer/isolators/network/port_mapping.cpp 938782ae2ab1da34eb316381131e9bfcb7c810d1
src/slave/flags.hpp 1e36c517ccebf42d18cd2534d40d98badd488cad
src/tests/allocator_tests.cpp 774528a61c937b2f6aa9fa3ecc59868070e21860
src/tests/authorization_tests.cpp a8fa4ccf4558532f6717f7a6e6301565aec7d5d1
src/tests/health_check_tests.cpp 731d944dd92ac325b0752655f8454f6ec7275c03
src/tests/master_authorization_tests.cpp f0f064808d8bf36a2a756bc907c477dd6440636c
src/tests/mesos.hpp b31c347299707cba242619c3dc6915f295bee9cb
src/tests/mesos.cpp 5bd8ba0bb56c9be9d0a3c49c27b6ebc03cfbdf7a
src/tests/port_mapping_tests.cpp a990da38bd1ff8dcfb6510ed4aa411253020ba20
src/tests/reconciliation_tests.cpp 3c4d7ed886333f0ccc1460178b9e06e7e38246c9
src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
src/tests/shutdown_tests.cpp 12ebef43a1ff339b30329d96d3c00646462ba37e
support/timed_tests.sh e060966b67089a60d4c93759bf907b3c8015e92f
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50120
-----------------------------------------------------------
Bad patch!
Reviews applied: [24264]
Failed command: git apply --index 24264.patch
Error:
error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply
- Mesos ReviewBot
On Aug. 7, 2014, 7 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 7 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 7, 2014, 7 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Aug. 6, 2014, 10:44 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, lines 977-978
> > <https://reviews.apache.org/r/24264/diff/2/?file=652336#file652336line977>
> >
> > Just my ignorance here, but do you need to specify --dist-dir= twice? Once for bdist_egg and once for bdist_wheel?
distutils in its infinite wisdom consumes the optional parameters between each step. Because `bdist_egg` and `bdist_wheel` are separate steps, they both need their own --dist-dir.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49824
-----------------------------------------------------------
On Aug. 6, 2014, 10:35 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 10:35 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Aug. 6, 2014, 10:44 p.m., Benjamin Hindman wrote:
> > mpi/mpiexec-mesos.in, line 32
> > <https://reviews.apache.org/r/24264/diff/2/?file=652335#file652335line32>
> >
> > Can we throw a comment above this block to explain what it is that you're doing? It's starting to get more and more complicated.
Looking at it, there's a way to simplify this whole thing significantly.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49824
-----------------------------------------------------------
On Aug. 7, 2014, 7 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 7 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49824
-----------------------------------------------------------
Ship it!
Cool. Mostly just a request for more comments so the next person that comes along understands what's happening can can easily amend or debug.
Also, see my comment re: bundling pip and wheel. Maybe for a follow up on this review, but I wonder if we check for pip/wheel at configure time and only build wheels and install if we have wheel. At some point we'll want to unbundle these dependencies too. At the very least, assuming this makes sense, capturing this as a TODO and even a JIRA ticket would be great!
mpi/mpiexec-mesos.in
<https://reviews.apache.org/r/24264/#comment87188>
Can we throw a comment above this block to explain what it is that you're doing? It's starting to get more and more complicated.
src/Makefile.am
<https://reviews.apache.org/r/24264/#comment87191>
Can you please leave a comment that explains how you go from a concrete egg (e.g., python/dist/mesos.interface-0.20.0-py2.7.egg) to the directory that you need to 'cd' into in order to run setup.py? That will help folks understand the magic in 'cd python/`echo $@ | awk -F"mesos[.]?" '{print $$2}' | cut -d- -f1`'.
Along with that comment, can you highlight that we build both eggs and wheels because we need to run the tests against the eggs (or in the event someone wants an egg) but we use wheels for installation because they can be uninstalled.
src/Makefile.am
<https://reviews.apache.org/r/24264/#comment87192>
Just my ignorance here, but do you need to specify --dist-dir= twice? Once for bdist_egg and once for bdist_wheel?
src/Makefile.am
<https://reviews.apache.org/r/24264/#comment87190>
Can we add a brief comment here explaining that rather than assuming 'pip' is installed we use the extracted 'pip' in 3rdparty, thus no call to 'pip' directly. Also, is there any reason not to require pip? I know Tim St Clair will ultimately want to "unbundle" this as he's doing for the rest of the 3rdparty dependencies.
- Benjamin Hindman
On Aug. 6, 2014, 10:35 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 10:35 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 10:35 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 8:10 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs (updated)
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am c741cdc9d59ad2c4e3132b080a8fcdd517942aa5
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [24264]
> >
> > Failed command: git apply --index 24264.patch
> >
> > Error:
> > error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
> > error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
> > error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
> > error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
> > error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
> > error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply
> >
>
> Thomas Rampelberg wrote:
> The files are in the patch. Did I miss something?
>
> Vinod Kone wrote:
> i suspect it's because of the binary files not being present in the diff. i remember we had this issue before. @benh: do you remember how to upload binary files to the diff?
I did a `git diff --full-index --binary master` and it looks like the patch includes the actual bytes. We'll see if reviewbot likes that or not.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49607
-----------------------------------------------------------
On Aug. 5, 2014, 8:10 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 8:10 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am c741cdc9d59ad2c4e3132b080a8fcdd517942aa5
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [24264]
> >
> > Failed command: git apply --index 24264.patch
> >
> > Error:
> > error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
> > error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
> > error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
> > error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
> > error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
> > error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply
> >
>
> Thomas Rampelberg wrote:
> The files are in the patch. Did I miss something?
i suspect it's because of the binary files not being present in the diff. i remember we had this issue before. @benh: do you remember how to upload binary files to the diff?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49607
-----------------------------------------------------------
On Aug. 4, 2014, 9:37 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 9:37 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [24264]
> >
> > Failed command: git apply --index 24264.patch
> >
> > Error:
> > error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
> > error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
> > error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
> > error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
> > error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
> > error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply
> >
The files are in the patch. Did I miss something?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49607
-----------------------------------------------------------
On Aug. 4, 2014, 9:37 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 9:37 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49607
-----------------------------------------------------------
Bad patch!
Reviews applied: [24264]
Failed command: git apply --index 24264.patch
Error:
error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply
- Mesos ReviewBot
On Aug. 4, 2014, 9:37 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 9:37 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
>
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
> 3rdparty/pip-1.5.6.tar.gz PRE-CREATION
> 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
> 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
> configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
> mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
> src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
> src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
> src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
> src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
>
> Diff: https://reviews.apache.org/r/24264/diff/
>
>
> Testing
> -------
>
> `make distcheck -j6`
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 9:37 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing (updated)
-------
`make distcheck -j6`
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 9:37 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 9:36 p.m.)
Review request for mesos.
Bugs: MESOS-899
https://issues.apache.org/jira/browse/MESOS-899
Repository: mesos-git
Description
-------
Because eggs are impossible to uninstall, pip + wheel has been added as a
packaging format. The wheels are generated in addition to eggs and then
subsequently installed/uninstalled.
Note that the building of eggs has not been removed. This is because wheels
cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
are needed for all the test scripts to run correctly without actually
installing anything locally.
Diffs
-----
3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0
3rdparty/pip-1.5.6.tar.gz PRE-CREATION
3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5
3rdparty/wheel-0.24.0.tar.gz PRE-CREATION
configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15
mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2
src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7
src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e
src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636
src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb
Diff: https://reviews.apache.org/r/24264/diff/
Testing
-------
Thanks,
Thomas Rampelberg